Date: Sat, 24 Dec 2022 22:18:45 +0900 From: =?UTF-8?B?SGlyb28gT25vICjlsI/ph47lr5vnlJ8p?= <hiroo.ono+freebsd@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: Mark Millard <marklmi@yahoo.com>, freebsd-arm@freebsd.org Subject: Re: Still did not succeed to boot on Lenovo Yoga C630 Message-ID: <CANtk6SjStgG4fR19ZCmK3SwMVCkTAP4q06zGj5ivdXASpjEFGg@mail.gmail.com> In-Reply-To: <CANtk6Sj9EiF1fjEPU6R4xhaTrUTuLCRTz2ZdkBQZoQv1qTY%2BZA@mail.gmail.com> References: <CANtk6SgUoqC_Jgdtu=CZnFvnLzqP445MQqfwhV5%2BBgX_%2BVFUZA@mail.gmail.com> <B55013C7-B04C-48E4-BC0F-C106DA08348F@yahoo.com> <CANtk6Shwaea09TiTZq3UZwzCoXjm8TqkA930QQwS_i3_Awd5bg@mail.gmail.com> <CANCZdfqpTW3AVHPfHPWOEpEW2QPTE6aADGNzhH=pQT4btA1%2BvQ@mail.gmail.com> <CANtk6Si4Eg3vd4j3wvgCt%2BoodpNK7ikei-XikEmXPMdQUane3w@mail.gmail.com> <CANCZdfpKnxeRp3RtPGrq%2BsCMqXjq0AnYWuN2orHt1qt57KRh0Q@mail.gmail.com> <CANtk6ShzbOcw%2B86J_M_AQeDHU36ptQG%2Bj7XndYzhCJ3E0N0Qqw@mail.gmail.com> <CANtk6ShVXDHt5K0UoGaMgw0o_w3HPCMPGYdu-m1hCUkZ3ZMcUQ@mail.gmail.com> <CANCZdfqyMUUDVgg4YHZNaXGVb9E8TXmFH0jtQuXN0TkCti46vQ@mail.gmail.com> <CANtk6SgeCFSwkRpXDd9DsR%2BN%2BNNa_c9pm6-8u6c9Q2au0ZiWZA@mail.gmail.com> <CANCZdfrF8P0FgU-E-n8hgNVshg3BBJuCuYOdTwEz4DMQ3mPDvg@mail.gmail.com> <CANtk6Sjs15P1oWyJcbzmHtmeHvkNjrqzcvo82qGm=PcheZmZoQ@mail.gmail.com> <CANtk6Sj9EiF1fjEPU6R4xhaTrUTuLCRTz2ZdkBQZoQv1qTY%2BZA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000090433705f092be5b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry again. The patch is needed for * stand/efi/loader/arch/arm64/start.S * stand/efi/loader/arch/arm64/ldscript.arm64 * stand/efi/loader/Makefile I forgot the last one. I remade the patch for three. 2022=E5=B9=B412=E6=9C=8824=E6=97=A5(=E5=9C=9F) 22:11 Hiroo Ono (=E5=B0=8F= =E9=87=8E=E5=AF=9B=E7=94=9F) <hiroo.ono+freebsd@gmail.com>: > > 2022=E5=B9=B412=E6=9C=8824=E6=97=A5(=E5=9C=9F) 10:35 Hiroo Ono (=E5=B0=8F= =E9=87=8E=E5=AF=9B=E7=94=9F) <hiroo.ono+freebsd@gmail.com>: > > > > > I run other arm64 machines w/o issue with the current code. > > > > Yes, Qualcomm's snapdragon is weird. I saw Linux people complain about > > it somewhere... Wanted to know before I bought this Yoga C630. > > > > 2022=E5=B9=B412=E6=9C=8824=E6=97=A5(=E5=9C=9F) 10:03 Warner Losh <imp@b= sdimp.com>: > > > > > > > > > > > > On Fri, Dec 23, 2022 at 5:49 PM Hiroo Ono (=E5=B0=8F=E9=87=8E=E5=AF= =9B=E7=94=9F) <hiroo.ono+freebsd@gmail.com> wrote: > > >> > > >> The current status of FreeBSD 14-current on Lenovo Yoga C630 is as f= ollows: > > >> > > >> 1) Merging from OpenBSD's loader code made the loader boot apart fr= om > > >> 3 points (#2 to 4 ). > > >> 2) when comconsole->c_init() runs the 2nd time, it seems to freeze. > > >> (might be C630 specific) > > >> 3) SetVirtualAddressMap() in efi_do_vmap() freezes. (might also > > >> affect other snapdragon systems like Microsoft Arm Developer Kit) > > >> 4) The kernel is kicked but does not start. > > >> > > >> 1) is quite straightforward. What needs to be changed is > > >> stand/efi/loader/arch/arm64/start.S. > > > > > > > > > Can you share what needs to be done? To my eye, we don't need any cha= nges, so it would be good to know what you've had to do exactly. > > > > Attached is the diff to start.S. There are 3 points. > > 1) The loader has to be aligned to 4kb. > > 2) Proper characteristic value should be in the PE header. > > 3) .text and .data segment have to be separate. > > > > It is from OpenBSD: > > https://github.com/openbsd/src/blob/master/sys/arch/arm64/stand/efiboot= /start.S > > Sorry patch to ldscript.arm64 was missing. > I am going to test your serial patch now. > > > > >> For 2), I do not know what to do. Currently, I commented out > > >> comconsole from struct console *consoles[] in stand/efi/loader/conf.= c > > >> as a workaround. Maybe, I should write a fault handler that helps > > >> returning from the fault. > > > > > > > > > There were problems with this with HyperV on aarch64 too. > > > > > > Something like > > > diff --git a/stand/efi/loader/efiserialio.c b/stand/efi/loader/efiser= ialio.c > > > index 8b3f8e83e0b3..54ee39096685 100644 > > > --- a/stand/efi/loader/efiserialio.c > > > +++ b/stand/efi/loader/efiserialio.c > > > @@ -261,11 +261,11 @@ comc_probe(struct console *sc) > > > if (comc_port =3D=3D NULL) > > > return; > > > } > > > - comc_port->baudrate =3D COMSPEED; > > > + comc_port->baudrate =3D 0; > > > comc_port->ioaddr =3D 0; /* default port */ > > > - comc_port->databits =3D 8; /* 8,n,1 */ > > > - comc_port->parity =3D NoParity; /* 8,n,1 */ > > > - comc_port->stopbits =3D OneStopBit; /* 8,n,1 */ > > > + comc_port->databits =3D 0; /* 8,n,1 */ > > > + comc_port->parity =3D 0; /* 8,n,1 */ > > > + comc_port->stopbits =3D 0; /* 8,n,1 */ > > > comc_port->ignore_cd =3D 1; /* ignore cd */ > > > comc_port->rtsdtr_off =3D 0; /* rts-dtr is on */ > > > comc_port->sio =3D NULL; > > > > > > was needed. Possibly the following would be better: > > > > > > diff --git a/stand/efi/loader/efiserialio.c b/stand/efi/loader/efiser= ialio.c > > > index 8b3f8e83e0b3..54ee39096685 100644 > > > --- a/stand/efi/loader/efiserialio.c > > > +++ b/stand/efi/loader/efiserialio.c > > > @@ -494,8 +494,7 @@ comc_setup(void) > > > return (false); > > > > > > status =3D comc_port->sio->SetAttributes(comc_port->sio, > > > - comc_port->baudrate, 0, 0, comc_port->parity, > > > - comc_port->databits, comc_port->stopbits); > > > + 0, 0, 0, 0, 0, 0); > > > if (EFI_ERROR(status)) > > > return (false); > > > --00000000000090433705f092be5b Content-Type: text/plain; charset="US-ASCII"; name="stand.diff.txt" Content-Disposition: attachment; filename="stand.diff.txt" Content-Transfer-Encoding: base64 Content-ID: <f_lc1ywa5p0> X-Attachment-Id: f_lc1ywa5p0 ZGlmZiAtLWdpdCBhL3N0YW5kL2VmaS9sb2FkZXIvTWFrZWZpbGUgYi9zdGFuZC9lZmkvbG9hZGVy L01ha2VmaWxlCmluZGV4IDJhYWJhNGZiYjM3Ny4uNDQ4M2Y1MjRlNDNhIDEwMDY0NAotLS0gYS9z dGFuZC9lZmkvbG9hZGVyL01ha2VmaWxlCisrKyBiL3N0YW5kL2VmaS9sb2FkZXIvTWFrZWZpbGUK QEAgLTExNCw4ICsxMTQsOSBAQCAke0xPQURFUn0uZWZpOiAke1BST0d9CiAJZmkKIAlTT1VSQ0Vf REFURV9FUE9DSD0ke1NPVVJDRV9EQVRFX0VQT0NIfSBcCiAJJHtPQkpDT1BZfSAtaiAucGVoZWFk ZXIgLWogLnRleHQgLWogLnNkYXRhIC1qIC5kYXRhIFwKLQkJLWogLmR5bmFtaWMgLWogLmR5bnN5 bSAtaiAucmVsLmR5biBcCi0JCS1qIC5yZWxhLmR5biAtaiAucmVsb2MgLWogLmVoX2ZyYW1lIC1q IHNldF9YY29tbWFuZF9zZXQgXAorCQktaiAuZHluYW1pYyAtaiAuZHluc3ltIC1qIC5keW5zdHIg LWogLnJlbCAtaiAucmVsLmR5biBcCisJCS1qIC5yZWxhIC1qIC5yZWxhLmR5biAtaiAucmVsb2Mg LWogLmVoX2ZyYW1lIFwKKwkJLWogc2V0X1hjb21tYW5kX3NldCBcCiAJCS1qIHNldF9YZmljbF9j b21waWxlX3NldCBcCiAJCS0tb3V0cHV0LXRhcmdldD0ke0VGSV9UQVJHRVR9ICR7LkFMTFNSQ30g JHsuVEFSR0VUfQogCmRpZmYgLS1naXQgYS9zdGFuZC9lZmkvbG9hZGVyL2FyY2gvYXJtNjQvbGRz Y3JpcHQuYXJtNjQgYi9zdGFuZC9lZmkvbG9hZGVyL2FyY2gvYXJtNjQvbGRzY3JpcHQuYXJtNjQK aW5kZXggZDBlZDMyMGEzMTljLi44YWJmNDEwNDI3M2UgMTAwNjQ0Ci0tLSBhL3N0YW5kL2VmaS9s b2FkZXIvYXJjaC9hcm02NC9sZHNjcmlwdC5hcm02NAorKysgYi9zdGFuZC9lZmkvbG9hZGVyL2Fy Y2gvYXJtNjQvbGRzY3JpcHQuYXJtNjQKQEAgLTE2LDcgKzE2LDkgQEAgU0VDVElPTlMKICAgICAq KC5nbnUud2FybmluZykKICAgICAqKC5wbHQpCiAgIH0gPTB4RDQyMDAwMDAKLSAgLiA9IEFMSUdO KDE2KTsKKyAgLiA9IEFMSUdOKDQwOTYpOworICBfZXRleHQgPSAuOworICBfX2RhdGFfc3RhcnQg PSAuOwogICAuZGF0YQkJOiB7CiAgICAgKigucm9kYXRhIC5yb2RhdGEuKiAuZ251LmxpbmtvbmNl LnIuKikKICAgICAqKC5yb2RhdGExKQpAQCAtNzcsMTAgKzc5LDExIEBAIFNFQ1RJT05TCiAgIC5y ZWxvYwk6IHsgKigucmVsb2MpIH0KICAgLiA9IEFMSUdOKDE2KTsKICAgLmR5bnN5bQk6IHsgKigu ZHluc3ltKSB9CisgIC5keW5zdHIJOiB7ICooLmR5bnN0cikgfQogICBfZWRhdGEgPSAuOworICBf X2RhdGFfc2l6ZSA9IC4gLSBfX2RhdGFfc3RhcnQ7CiAKICAgLyogVW51c2VkIHNlY3Rpb25zICov CiAgIC5pbnRlcnAJOiB7ICooLmludGVycCkgfQotICAuZHluc3RyCTogeyAqKC5keW5zdHIpIH0K ICAgLmhhc2gJCTogeyAqKC5oYXNoKSB9CiB9CmRpZmYgLS1naXQgYS9zdGFuZC9lZmkvbG9hZGVy L2FyY2gvYXJtNjQvc3RhcnQuUyBiL3N0YW5kL2VmaS9sb2FkZXIvYXJjaC9hcm02NC9zdGFydC5T CmluZGV4IDY3NWQ0ZTE1M2YzNi4uMzdlMTE3ZDY3OWEwIDEwMDY0NAotLS0gYS9zdGFuZC9lZmkv bG9hZGVyL2FyY2gvYXJtNjQvc3RhcnQuUworKysgYi9zdGFuZC9lZmkvbG9hZGVyL2FyY2gvYXJt NjQvc3RhcnQuUwpAQCAtMzksNiArMzksNyBAQAogI2RlZmluZQlJTUFHRV9TQ05fTUVNX0RJU0NB UkRBQkxFCTB4MDIwMDAwMDAKICNkZWZpbmUJSU1BR0VfU0NOX01FTV9FWEVDVVRFCQkweDIwMDAw MDAwCiAjZGVmaW5lCUlNQUdFX1NDTl9NRU1fUkVBRAkJMHg0MDAwMDAwMAorI2RlZmluZQlJTUFH RV9TQ05fTUVNX1dSSVRFCQkweDgwMDAwMDAwCiAKIAkuc2VjdGlvbiAucGVoZWFkZXIsImEiCiBl Zmlfc3RhcnQ6CkBAIC01NSwyNyArNTYsMjcgQEAgcGVfc2lnOgogCS5zaG9ydAkwCiBjb2ZmX2hl YWQ6CiAJLnNob3J0CUlNQUdFX0ZJTEVfTUFDSElORV9BUk02NAkvKiBBQXJjaDY0IGZpbGUgKi8K LQkuc2hvcnQJMgkJCQkvKiAyIFNlY3Rpb25zICovCisJLnNob3J0CTMJCQkJLyogMiBTZWN0aW9u cyAqLwogCS5sb25nCTAJCQkJLyogVGltZXN0YW1wICovCiAJLmxvbmcJMAkJCQkvKiBObyBzeW1i b2wgdGFibGUgKi8KIAkubG9uZwkwCQkJCS8qIE5vIHN5bWJvbHMgKi8KIAkuc2hvcnQJc2VjdGlv bl90YWJsZSAtIG9wdGlvbmFsX2hlYWRlcgkvKiBPcHRpb25hbCBoZWFkZXIgc2l6ZSAqLwotCS5z aG9ydAkwCS8qIENoYXJhY3RlcmlzdGljcyBUT0RPOiBGaWxsIGluICovCisJLnNob3J0CTB4MDIw NgkJCQkvKiBDaGFyYWN0ZXJpc3RpY3MgKi8KIAogb3B0aW9uYWxfaGVhZGVyOgogCS5zaG9ydAkw eDAyMGIJCQkJLyogUEUzMisgKDY0LWJpdCBhZGRyZXNzaW5nKSAqLwogCS5ieXRlCTAJCQkJLyog TWFqb3IgbGlua2VyIHZlcnNpb24gKi8KIAkuYnl0ZQkwCQkJCS8qIE1pbm9yIGxpbmtlciB2ZXJz aW9uICovCi0JLmxvbmcJX2VkYXRhIC0gX2VuZF9oZWFkZXIJCS8qIENvZGUgc2l6ZSAqLwotCS5s b25nCTAJCQkJLyogTm8gaW5pdGlhbGl6ZWQgZGF0YSAqLworCS5sb25nCV9ldGV4dCAtIF9lbmRf aGVhZGVyCQkvKiBDb2RlIHNpemUgKi8KKwkubG9uZwlfX2RhdGFfc2l6ZQkJCS8qIE5vIGluaXRp YWxpemVkIGRhdGEgKi8KIAkubG9uZwkwCQkJCS8qIE5vIHVuaW5pdGlhbGl6ZWQgZGF0YSAqLwog CS5sb25nCV9zdGFydCAtIGVmaV9zdGFydAkJLyogRW50cnkgcG9pbnQgKi8KIAkubG9uZwlfZW5k X2hlYWRlciAtIGVmaV9zdGFydAkJLyogU3RhcnQgb2YgY29kZSAqLwogCiBvcHRpb25hbF93aW5k b3dzX2hlYWRlcjoKIAkucXVhZAkwCQkJCS8qIEltYWdlIGJhc2UgKi8KLQkubG9uZwkzMgkJCQkv KiBTZWN0aW9uIEFsaWdubWVudCAqLwotCS5sb25nCTgJCQkJLyogRmlsZSBhbGlnbm1lbnQgKi8K KwkubG9uZwk0MDk2CQkJCS8qIFNlY3Rpb24gQWxpZ25tZW50ICovCisJLmxvbmcJNTEyCQkJCS8q IEZpbGUgYWxpZ25tZW50ICovCiAJLnNob3J0CTAJCQkJLyogTWFqb3IgT1MgdmVyc2lvbiAqLwog CS5zaG9ydAkwCQkJCS8qIE1pbm9yIE9TIHZlcnNpb24gKi8KIAkuc2hvcnQJMAkJCQkvKiBNYWpv ciBpbWFnZSB2ZXJzaW9uICovCkBAIC0xMjQsOSArMTI1LDkgQEAgc2VjdGlvbl90YWJsZToKIAku Ynl0ZQkwCiAJLmJ5dGUJMAogCS5ieXRlCTAJCQkJLyogUGFkIHRvIDggYnl0ZXMgKi8KLQkubG9u ZwlfZWRhdGEgLSBfZW5kX2hlYWRlcgkJLyogVmlydHVhbCBzaXplICovCisJLmxvbmcJX2V0ZXh0 IC0gX2VuZF9oZWFkZXIJCS8qIFZpcnR1YWwgc2l6ZSAqLwogCS5sb25nCV9lbmRfaGVhZGVyIC0g ZWZpX3N0YXJ0CQkvKiBWaXJ0dWFsIGFkZHJlc3MgKi8KLQkubG9uZwlfZWRhdGEgLSBfZW5kX2hl YWRlcgkJLyogU2l6ZSBvZiByYXcgZGF0YSAqLworCS5sb25nCV9ldGV4dCAtIF9lbmRfaGVhZGVy CQkvKiBTaXplIG9mIHJhdyBkYXRhICovCiAJLmxvbmcJX2VuZF9oZWFkZXIgLSBlZmlfc3RhcnQJ CS8qIFBvaW50ZXIgdG8gcmF3IGRhdGEgKi8KIAkubG9uZwkwCQkJCS8qIFBvaW50ZXIgdG8gcmVs b2NhdGlvbnMgKi8KIAkubG9uZwkwCQkJCS8qIFBvaW50ZXIgdG8gbGluZSBudW1iZXJzICovCkBA IC0xMzQsNiArMTM1LDI0IEBAIHNlY3Rpb25fdGFibGU6CiAJLnNob3J0CTAJCQkJLyogTnVtYmVy IG9mIGxpbmUgbnVtYmVycyAqLwogCS5sb25nCShJTUFHRV9TQ05fQ05UX0NPREUgfCBJTUFHRV9T Q05fTUVNX0VYRUNVVEUgfCBcCiAJCSBJTUFHRV9TQ05fTUVNX1JFQUQpCQkvKiBDaGFyYWN0ZXJp c3RpY3MgKi8KKworCS8qIFRoZSBjb250ZW50cyBvZiB0aGUgbG9hZGVyICovCisJLmFzY2lpCSIu ZGF0YSIKKwkuYnl0ZQkwCisJLmJ5dGUJMAorCS5ieXRlCTAJCQkJLyogUGFkIHRvIDggYnl0ZXMg Ki8KKwkubG9uZwlfX2RhdGFfc2l6ZQkJCS8qIFZpcnR1YWwgc2l6ZSAqLworCS5sb25nCV9fZGF0 YV9zdGFydCAtIGVmaV9zdGFydAkvKiBWaXJ0dWFsIGFkZHJlc3MgKi8KKwkubG9uZwlfX2RhdGFf c2l6ZQkJCS8qIFNpemUgb2YgcmF3IGRhdGEgKi8KKwkubG9uZwlfX2RhdGFfc3RhcnQgLSBlZmlf c3RhcnQJLyogUG9pbnRlciB0byByYXcgZGF0YSAqLworCS5sb25nCTAJCQkJLyogUG9pbnRlciB0 byByZWxvY2F0aW9ucyAqLworCS5sb25nCTAJCQkJLyogUG9pbnRlciB0byBsaW5lIG51bWJlcnMg Ki8KKwkuc2hvcnQJMAkJCQkvKiBOdW1iZXIgb2YgcmVsb2NhdGlvbnMgKi8KKwkuc2hvcnQJMAkJ CQkvKiBOdW1iZXIgb2YgbGluZSBudW1iZXJzICovCisJLmxvbmcJKElNQUdFX1NDTl9DTlRfSU5J VElBTElaRURfREFUQSB8IElNQUdFX1NDTl9NRU1fUkVBRCB8IFwKKwkJIElNQUdFX1NDTl9NRU1f V1JJVEUpCQkvKiBDaGFyYWN0ZXJpc3RpY3MgKi8KKworCS5hbGlnbgkxMgogX2VuZF9oZWFkZXI6 CiAKIAkudGV4dApAQCAtMTg1LDMgKzIwNCw2IEBAIGluaXRzdGFjazoKIAkuc3BhY2UJKDY0ICog MTAyNCkKIGluaXRzdGFja19lbmQ6CiAjZW5kaWYKKworCS5kYXRhCisJLmFsaWduCTQK --00000000000090433705f092be5b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANtk6SjStgG4fR19ZCmK3SwMVCkTAP4q06zGj5ivdXASpjEFGg>