From owner-cvs-all@FreeBSD.ORG  Wed Jul 23 11:32:18 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 428D637B401; Wed, 23 Jul 2003 11:32:18 -0700 (PDT)
Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2586D43F85; Wed, 23 Jul 2003 11:32:17 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6NIWFV3047709;
	Wed, 23 Jul 2003 18:32:15 GMT
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6NIWE5H024543;
	Wed, 23 Jul 2003 20:32:15 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: John Baldwin <jhb@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 23 Jul 2003 14:24:00 EDT."
             <XFMail.20030723142400.jhb@FreeBSD.org> 
Date: Wed, 23 Jul 2003 20:32:14 +0200
Message-ID: <24542.1058985134@critter.freebsd.dk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/rp rp.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jul 2003 18:32:18 -0000

In message <XFMail.20030723142400.jhb@FreeBSD.org>, John Baldwin writes:
>
>On 23-Jul-2003 Poul-Henning Kamp wrote:
>> phk         2003/07/23 11:03:23 PDT
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/dev/rp           rp.c 
>>   Log:
>>   Undo single-intance inlining which is way above the comfort limit for GCC.
>
>Single instance inlining can not hurt.  It can help by reducing call
>stack depth and code size however.  I thought you were for reducing code
>size, not increasing it.  Please use __always_inline to shut up gcc
>instead of de-inlining for single instance inlines.

Please provide data showing actual improvement for inlining.

If I changed this to __always_inline, I would change the code generated,
to start inlining these functions.  We don't know the effect of that.

Instead I preserve the status quo by removing the inline request which
GCC ignores.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.