Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 09 Jul 2016 11:08:52 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-fs@FreeBSD.org
Subject:   [Bug 203864] ZFS deadlock between zfs send, zfs rename and ctrl-C
Message-ID:  <bug-203864-3630-juE3XsyRUC@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-203864-3630@https.bugs.freebsd.org/bugzilla/>
References:  <bug-203864-3630@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D203864

--- Comment #17 from Andriy Gapon <avg@FreeBSD.org> ---
Another observation is that the current code seems to be broken in a couple=
 of
places as well.

1. dsl_dataset_rename_snapshot_sync_impl() uses ddrsa_fsname to construct t=
he
old and new snapshot names, but this would be wrong in the case of a recurs=
ive
snpashot rename (zfs rename -r x@snap1 x@snap2) as ddrsa_fsname always poin=
ts
to the name of the top level filesystem.

2. dsl_dataset_promote_sync(): as far as I can see, oldname is never popula=
ted,
so the code can do arbitrary renames.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-203864-3630-juE3XsyRUC>