From owner-svn-ports-all@freebsd.org Mon Feb 15 22:11:51 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5E16A53C9A3; Mon, 15 Feb 2021 22:11:51 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfdcQ3z72z3khr; Mon, 15 Feb 2021 22:11:50 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: by mail-qv1-xf2c.google.com with SMTP id dr7so3854866qvb.1; Mon, 15 Feb 2021 14:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+KEQTNwfhQqzcZ6iA8dTg2zaC+IAmRyMF9SKrs+5SQw=; b=kT+HlfluXJvppIE2kovRNuJmdHfJ3ujKjAtzFlC+Q3rYddrIq9O/yw0hmsLujg03gq /dPQhJxnogTt0kln3Ghg3YYx+7fRZaU9sZU3qdFY9oK3VfJlnAfvd/Hpa65ep/sRMczg YEWOsMauysiANEZpRA1qGoVXquTOMG5SyXThE8f1XU+wKoU49rxDDZqXvtIB0N0I4HXJ 0p09hanM3x1gcPHU64UPtczLgFy5ouLqW/i0xPx6Ahb/ScmYUFT5g3TdD1HmDa6d8pgn me6iRZV8bOB2Elo9731sed1dxfW3CfhtEd88h1Tmni3XizVW8TW5TxWLB2K5p0iJdPeZ YxDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+KEQTNwfhQqzcZ6iA8dTg2zaC+IAmRyMF9SKrs+5SQw=; b=iDno6Y4JH6TYIU5Rk54gFIyQLs3AI3dJeQwtcoNvbPNa9UwQ7qn4KWOxDIp11ovNRY hKjBVqQ7kZ2uGTRM+xA+Ezq72LcTe7Bd4cmwaZ2AXMwm2XjUU/Q83uYhNzx4M01iWsHI qLg7IUfYNvSxk79IZdjY4HNzd0AS8m8IXsoOO7A4hk+e1mvHxrLQ83LNyWfPQRNeMzsD sfwxYETZQhXLeNc8C2f53wYhrCDZaLwiUxotf32Gtj8y3VCwa5e0NRWQZ+o630bh1uj7 HBPkI24Ua/BWispDOsQGL15PQWDtLFSSnTeMt1m3vraD0RNWLrWGiSFQRRU1jOlC03Mf hh6A== X-Gm-Message-State: AOAM532gEVoDUEuxyO5dWOhN2FajlBzMz/FAbpemlcMzeq7hB7aMfu3Q sBB1KiFWN4doFz3ctOfmn6EGC289Ge6CCg== X-Google-Smtp-Source: ABdhPJxjL8H/BkHbQVprGwqh/5BnffqCmyPflAn39CEkC+ZR4lPhGXibMnnWOoisMhaOjIMAVsW/Jw== X-Received: by 2002:a0c:c488:: with SMTP id u8mr16842836qvi.9.1613427109307; Mon, 15 Feb 2021 14:11:49 -0800 (PST) Received: from coral.acadix.biz (2603-6000-a401-3a00-0223-24ff-fe37-c4d7.res6.spectrum.com. [2603:6000:a401:3a00:223:24ff:fe37:c4d7]) by smtp.gmail.com with ESMTPSA id b16sm11723197qtx.85.2021.02.15.14.11.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Feb 2021 14:11:48 -0800 (PST) Subject: Re: svn commit: r565224 - in head/lang/pocl: . files To: Christoph Moench-Tegeder Cc: "Jason W. Bacon" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202102141304.11ED4BTl046406@repo.freebsd.org> From: Jason Bacon Message-ID: <604f421a-4b9e-2fd7-bb90-1e0cc0ac9b03@gmail.com> Date: Mon, 15 Feb 2021 16:11:22 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Rspamd-Queue-Id: 4DfdcQ3z72z3khr X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=kT+Hlflu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of bacon4000@gmail.com designates 2607:f8b0:4864:20::f2c as permitted sender) smtp.mailfrom=bacon4000@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-0.999]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::f2c:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::f2c:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f2c:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-ports-head,svn-ports-all] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 22:11:51 -0000 On 2/14/21 2:41 PM, Christoph Moench-Tegeder wrote: > ## Jason Bacon (bacon4000@gmail.com): > >>> First, while I'm all in favor of consistent white space, mixing this >>> with the stated (per commit message) change makes the diff harder >>> to read and "svn annotate" (and similar tools) harder to use later on= =2E >> Are you suggesting that whitespace changes should be done in a separat= e >> commit? > Perhaps I wouldn't put it that strongly. More like "think about how tha= t > looks like in the commit history". > This is not a policy, but some options: > - if you're changing a line anyways, fix the whitespace there at the > same time > - lines which will never or rarely change (PORTNAME, MAINTAINER, ...) > could be whitespace-fixed in their own commit > - fix the whitespace across the whole file first, then do whatever "rea= l" > change you want to do > - depending on how much you change anyways, it might even not matter > that much if you "just fix the whitespace on the side". > > The guiding principle should be to retain the usefulness of the > commit diffs and the history: searching that one "real" change in > dozens of lines of whitespace-only diff can be frustrating, and > running "{svn,git} annotate" just to end up at that one "fix whitespace= " > commit also does not help. > > Regards, > Christoph > Sounds reasonable, thanks for the detailed clarification. Best, =C2=A0=C2=A0=C2=A0 JB --=20 Earth is a beta site.