From owner-svn-src-all@freebsd.org Wed Apr 29 16:19:14 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9F9402BA8C9; Wed, 29 Apr 2020 16:19:14 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49C3cK5xBrz4TNl; Wed, 29 Apr 2020 16:19:13 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: by mail-wr1-x441.google.com with SMTP id x18so3277217wrq.2; Wed, 29 Apr 2020 09:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:reply-to:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pwsqVopy8MV9a7r+fbaj0LnmP4A5NJ3Cp+flWmeuY3k=; b=XIVxuH4LuVoGM9DMHGu9esG42b/qdVyFHtasVS0p+c7hHgMH0MQ7AHw8obXW9uzYnZ Q0TQQjSVwQnSSnRzN6S3OhKcFmYZlVBHg4RZyCVAzN7TVnhOIEAVzykMJZb0Ky64Uyd+ 39zVnQFhlWkinmC8wo9616it5jnaVRDf7MqnyhshppD4rvlmf3vPE2F9nbi2DWJnTDdn YE/wg1nJpRXs0YlXcQIrSnE+VmnTSUZpGoomzuiAoL0GH7qNxuQ4ZsLLPl4kISmvwMHx M7AFEUfyW81IVZTzHXZMLfIE5XUkOSKeB7YxeE+yAKECNBEDTo+xr3gWEP+LRrGiXoL8 /ZdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=pwsqVopy8MV9a7r+fbaj0LnmP4A5NJ3Cp+flWmeuY3k=; b=CBuvbkj/7acqLxUhe/AMLkVM/wwNYIWaFuGBq+q3+9BpAb3OEe3xL4bSNHFv5Rp2g+ pkUvKv2ophgTT5rM74bsiigi/OLga00He0KTwYtvEhzZJlWF8Viz28ZOkFLIMLKSD3Vb XRRoaEisN3f9yMlyYZltzdsvlyJcHLqxTUsCq+mFwbtOry/1PtNZmUmWmA5UH2HxNA5+ 1ftwoAtSgaaJ/Le5o9NSqHKN4nLbGf6juVXK0ZZ5CQ8u4LgeyepvX8xuodcDIIJ4TH4D 9MxCVxvLnAifmF1Tg3FWrhMxdioIdAfhUZKRmyEONanzY4uJbEpIOzQkDXT4SjVO+LvD usaQ== X-Gm-Message-State: AGi0PuZIqd3fkG+Dwf3Mq0vbTco1ZARL4z1EDf7CKteyqMAx+3kkds0j Y1gozMG6kXwHaQc1HZLL6389OhX1 X-Google-Smtp-Source: APiQypJEDOIdejT9A582LOEE3fZJ4mlDahhSkgMCZ7cIE40QwJF/2acfEKvOXvEKeyvrGQ7UCyaTsg== X-Received: by 2002:a5d:5651:: with SMTP id j17mr39117436wrw.406.1588177152075; Wed, 29 Apr 2020 09:19:12 -0700 (PDT) Received: from [88.208.79.100] (halouny.humusoft.cz. [88.208.79.100]) by smtp.gmail.com with ESMTPSA id d13sm8292585wmb.39.2020.04.29.09.19.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2020 09:19:11 -0700 (PDT) Sender: Michal Meloun From: Michal Meloun X-Google-Original-From: Michal Meloun Reply-To: mmel@freebsd.org Subject: Re: svn commit: r360463 - head/libexec/rtld-elf To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202004291406.03TE6g1c031338@repo.freebsd.org> <20200429152030.GB2522@kib.kiev.ua> Message-ID: <254296a0-dfde-e562-fc45-d819c41f75ca@freebsd.org> Date: Wed, 29 Apr 2020 18:19:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200429152030.GB2522@kib.kiev.ua> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49C3cK5xBrz4TNl X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=XIVxuH4L; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of melounmichal@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) smtp.mailfrom=melounmichal@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[mmel@freebsd.org]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (2.36), ipnet: 2a00:1450::/32(-2.32), asn: 15169(-0.43), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[1.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 16:19:14 -0000 On 29.04.2020 17:20, Konstantin Belousov wrote: > On Wed, Apr 29, 2020 at 02:06:42PM +0000, Michal Meloun wrote: >> Author: mmel >> Date: Wed Apr 29 14:06:42 2020 >> New Revision: 360463 >> URL: https://svnweb.freebsd.org/changeset/base/360463 >> >> Log: >> Don't allow to use FPU inside of rtld library. >> Clang10 may use FPU instructions for optimizing operations with >> memory blocks. But we don't want to do lengthy save/restore of all >> FPU registers across each rtld_start() call. >> >> MFC after: 3 week >> >> Modified: >> head/libexec/rtld-elf/Makefile >> >> Modified: head/libexec/rtld-elf/Makefile >> ============================================================================== >> --- head/libexec/rtld-elf/Makefile Wed Apr 29 13:45:21 2020 (r360462) >> +++ head/libexec/rtld-elf/Makefile Wed Apr 29 14:06:42 2020 (r360463) >> @@ -48,6 +48,9 @@ MLINKS?= rtld.1 ld-elf.so.1.1 \ >> rtld.1 ld.so.1 >> >> CFLAGS+= -fpic -DPIC $(DEBUG) >> +CFLAGS.armv6+= -mfpu=none >> +CFLAGS.armv7+= -mfpu=none > I cleaned rtld-elf/Makefile of all MD bits, please move this to > arm/Makefile.inc. > Done in r360469. arm/Makefile.inc is, of course, much better place for these flags. Thanks for pointing me me on this. Michal >> + >> LDFLAGS+= -shared -Wl,-Bsymbolic -Wl,-z,defs -nostdlib -e ${RTLD_ENTRY} >> # Pull in the dependencies that we use from libc >> .include "rtld-libc/Makefile.inc"