From owner-freebsd-fs@FreeBSD.ORG Wed Jul 23 14:16:23 2014 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 176119A7 for ; Wed, 23 Jul 2014 14:16:23 +0000 (UTC) Received: from thebighonker.lerctr.org (thebighonker.lerctr.org [IPv6:2001:470:1f0f:3ad:223:7dff:fe9e:6e8a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "thebighonker.lerctr.org", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E229D2031 for ; Wed, 23 Jul 2014 14:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=lerami; h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date; bh=PYjUqG8D623UT3cy2cjda0IffncUbhDIRUVMJnIlByA=; b=YLrbOAtUGXzawcMEvIUaUTZIDuzUCIoP5J1elu+R/I1x7vEy8hZyKbQUFwF4kXS3GFCatP0X/2vkHypoXjS/ImxDCZ0NPu1rxi0Cdex2DbYy0Fg01v4ySf95Pr8yvg2BQ9qIFXkAU+sQTcn36ttn4n86NuAYUGcEpK+W9Iy4+Kw=; Received: from 107-128-180-255.lightspeed.austtx.sbcglobal.net ([107.128.180.255]:28219 helo=borg.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.83 (FreeBSD)) (envelope-from ) id 1X9xLA-000BWo-Gc for freebsd-fs@freebsd.org; Wed, 23 Jul 2014 09:16:21 -0500 Date: Wed, 23 Jul 2014 09:16:09 -0500 From: Larry Rosenman To: freebsd-fs@freebsd.org Subject: 2 asserts that I've had issues with.... Message-ID: <20140723141609.GA71261@borg.lerctr.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-LERCTR-Spam-Score: -2.9 (--) X-Spam-Report: SpamScore (-2.9/5.0) ALL_TRUSTED=-1, BAYES_00=-1.9, TVD_RCVD_IP=0.001 X-LERCTR-Spam-Report: SpamScore (-2.9/5.0) ALL_TRUSTED=-1, BAYES_00=-1.9, TVD_RCVD_IP=0.001 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2014 14:16:23 -0000 I've had the following 2 asserts #if'd out for a while. I was seeing lots of panics from them.... 2 questions: 1) is it a real issue? 2) how can I find the offending block(s) on disk? Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zap.c =================================================================== --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zap.c (revision 269010) +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zap.c (working copy) @@ -476,7 +476,9 @@ * chain. There should be no chained leafs (as we have removed * support for them). */ +#if 0 /*LER: to see what else blows up */ ASSERT0(l->l_phys->l_hdr.lh_pad1); +#endif /* * There should be more hash entries than there can be @@ -531,7 +533,9 @@ ASSERT3U(l->l_blkid, ==, blkid); ASSERT3P(l->l_dbuf, ==, db); ASSERT3P(l->l_phys, ==, l->l_dbuf->db_data); +#if 0 /* LER */ ASSERT3U(l->l_phys->l_hdr.lh_block_type, ==, ZBT_LEAF); +#endif ASSERT3U(l->l_phys->l_hdr.lh_magic, ==, ZAP_LEAF_MAGIC); *lp = l; borg.lerctr.org /usr/src # Thanks. -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: ler@lerctr.org US Mail: 108 Turvey Cove, Hutto, TX 78634-5688