From owner-svn-src-all@freebsd.org Fri Feb 26 16:45:25 2021 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0EE77566D80; Fri, 26 Feb 2021 16:45:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnFrj01vsz4XhG; Fri, 26 Feb 2021 16:45:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 772332373; Fri, 26 Feb 2021 16:45:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: svn commit: r363263 - in head/lib/csu: . common To: Kyle Evans Cc: src-committers , svn-src-all , svn-src-head References: <202007162158.06GLwh9N034510@repo.freebsd.org> From: John Baldwin Message-ID: <1b60cbd0-c891-7d44-c0d3-809586b16807@FreeBSD.org> Date: Fri, 26 Feb 2021 08:45:23 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 16:45:25 -0000 On 2/26/21 6:02 AM, Kyle Evans wrote: > On Thu, Jul 16, 2020 at 4:58 PM John Baldwin wrote: >> >> Author: jhb >> Date: Thu Jul 16 21:58:43 2020 >> New Revision: 363263 >> URL: https://svnweb.freebsd.org/changeset/base/363263 >> >> Log: >> Include ABI note tag in shared libraries. >> >> Split the ELF feature note into a separate file that is linked into >> *crt1.o the same as crtbrand.S was before. crtbrand.o is now linked >> into crti.o on all platforms in addition to *crt1.o. >> > > This is pretty handy; any chance we can backport this series for 12.3? So there is an issue I need to resolve in that the notes can get lost if you use --gc-sections which LLVM does when building the cross toolchain (so the trick of using .comdat for notes doesn't end up working out). Right now it only fully breaks RISC-V since all the other arches still have FreeBSD set as the ELF OSABI in the ELF header. -- John Baldwin