From nobody Thu Feb 26 14:33:55 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fMDVC4Dyfz6SYHl for ; Thu, 26 Feb 2026 14:33:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fMDVC18wwz3GwL for ; Thu, 26 Feb 2026 14:33:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772116435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=T3fZehh2H6pfo4QURNAVP2HoypvLAUASh2+xyvLQWLo=; b=DypCZFEmhCEfB7f26teMKk8QplfxYoTJUM56p5cuyrkkNR5fBm1EbAExKEZnIEhqhY9uzO +F/TvWaEWakZmi5vw7g3dVzEgGMhDMBqK2PyLzLKmHM4LCJE5O8Z0aUY5Ct9eu1y8Y4Hvu /IVo5MKhj4vcpHfVffxJ0OSZiApK005vpcQjUvjOkWr8svxQcD/92RSDW0VRhiRaPabCqq 1k5AmJpRlMOmmpMLZ0YK9+9qVtxWGnh8LfCAYZNg4w+JVgKYNAXQgrLLJsHc6regcNVEEC SDWTGG4fN41rYc4R7h/eLT/vqZRz5xA0XnBCm77WwznGbHcNE0D6OiGPKcDjng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772116435; a=rsa-sha256; cv=none; b=FWaU5q1TwdRnG5+WvI8mfiKdje5Mr0LzLAwFua2L5YUXDQGqAjtR44v8T7NiOfhdAaswXh w0N5DSFn92Nk8GwnwrJsX8kyiBcQvIataa3wQRJ+ZFq3T5sQIiJcWNNG4M4QQ+BgS7reK+ jsO/1aPJ7ZXs3egwPnYRXSKJ54q/U0uVpY7O1y82Uu+8DKIoycoJayyaniPjm7xjJ2uV4Q 1JGHviTicA5zNsiBZtG7ljAWsU857LLWY2Z8X2xc0hullpZmpYDxO2Wcbh/Kp+YHp0186Z PsdgMi5c9OAhNrE2vkM/F1+arl2nH81OyZ2rLFaNLWhk8h6A4/ckWbbLc5unfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772116435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=T3fZehh2H6pfo4QURNAVP2HoypvLAUASh2+xyvLQWLo=; b=a17lZ3KLV10/bMY46MV7pC+w0ntbm28oGJ2jbZtN5pvK5re+z7dl26PzSvpiZDx0o+Y5s3 aKoyxXV1KFL2ykul6Vx9Q2fAHSXSnM/JcHi1MUyRyUlVoY5EkTvwEC2DFR2bbXwheItdOn e5aZOnam2KW4IfzhnvpNYS+WCHwKDeDnBWf4WA059jc7mrcR5uB6JYWv+bDWm7dq0IEmiP U2ACCGcYq5HTVPXhUY4xiNG/TU7Q9BMUYx4ejMQNiqXHTyT3i7lWdQV7t32fyxcEiG662h 86rR3NSOnCRxcm4OrkUxI0ev81Qr15vNLQqq2fN8pRvRyPtoIpT0kpzA2ldZdQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fMDVC0lVvzbp6 for ; Thu, 26 Feb 2026 14:33:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26b40 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 26 Feb 2026 14:33:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 59c399d38dd8 - stable/13 - qlnxe: Remove a pointless copy back from the link-layer address List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 59c399d38dd8c711a9b9ae2f6614eed80afdde63 Auto-Submitted: auto-generated Date: Thu, 26 Feb 2026 14:33:55 +0000 Message-Id: <69a059d3.26b40.4eacf74f@gitrepo.freebsd.org> The branch stable/13 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=59c399d38dd8c711a9b9ae2f6614eed80afdde63 commit 59c399d38dd8c711a9b9ae2f6614eed80afdde63 Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:53 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-26 14:17:22 +0000 qlnxe: Remove a pointless copy back from the link-layer address On ifnet attaching, ether_ifattach() makes the link-layer address by shadow copying the ha->primary_mac. Well, the link-layer address will not be altered during attaching, thus it is pointless to copy it back. No functional change intended. Reviewed by: kbowling MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54883 (cherry picked from commit 4ac3081b282800158df7abe93f307d76e1b5b808) (cherry picked from commit 23ffd1650cc431e762387d384ede99ae085bc130) (cherry picked from commit 7d7cee09b9a4ac5cbcbac79cb7ccfef5d6db1e0f) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index ad7843dd5596..c1179d83a679 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2440,8 +2440,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) ifmedia_set(&ha->media, (IFM_ETHER | IFM_AUTO)); ether_ifattach(ifp, ha->primary_mac); - bcopy(IF_LLADDR(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN); - QL_DPRINT2(ha, "exit\n"); return;