Date: Tue, 3 May 2016 14:29:09 -0600 From: Warner Losh <imp@bsdimp.com> To: cem@FreeBSD.org Cc: Oliver Pinter <oliver.pinter@hardenedbsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298665 - head/sys/dev/aacraid Message-ID: <A26C4B8A-DD67-4F57-9E26-3DEADE7C82F1@bsdimp.com> In-Reply-To: <CAG6CVpWz6phJMzXoZARxUKQg7D1sV3xvdyui8tEftO4eJK1zJg@mail.gmail.com> References: <201604262059.u3QKxLDl045059@repo.freebsd.org> <CAPQ4ffvro_5bV_OdH=OLBN8o1Ui%2BvCgi7kBbHjwnoMTAtbo%2B%2BQ@mail.gmail.com> <CAG6CVpWz6phJMzXoZARxUKQg7D1sV3xvdyui8tEftO4eJK1zJg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_E1A310D5-E2E5-4A5C-BC80-4BEA56058EDA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 3, 2016, at 1:44 PM, Conrad Meyer <cem@FreeBSD.org> wrote: >=20 > On Tue, May 3, 2016 at 12:00 PM, Oliver Pinter > <oliver.pinter@hardenedbsd.org> wrote: >> strlcpy instead or adjust the p->vendors size? >=20 > Neither. The buffer is intentionally not nul-terminated. The > coverity reports are false positives. Then wouldn=E2=80=99t memcmp be better? Warner --Apple-Mail=_E1A310D5-E2E5-4A5C-BC80-4BEA56058EDA Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXKQoVAAoJEGwc0Sh9sBEAStgQAM8Gx4YYrJiIRBfXfgQdg+/T /gQGH5nQZ52BD8G9qdZ0qHL9yahhQ3kg+X5qJ3+9d+VXclhHiFRSF2/56h1OXxPL RiTsO1L3zt9yYcsyMtHeNXnLFty5HUIwmgPV1hkT+gmgCLFcrin98Qy+DwVvq+Fp NqB47EBFTGiXyht8KoEwWOJNcVAKPgzrrpyCupGjrTw86qZMbz+3n5MrVVjg3cRk a00vkcYA8gpk2IeF/bjXtyLRFMzwrq7NiO84WCxqyOkq1LjHBLX7InTJ6xYJCBK/ pJu2LFvblDG3nB025HGjScW+8d1zsjyMTnsRVbsa5ja7vVYMjOPleQFCVMsGav8f n9PWu+XKMsiNgszm/PjxQzQm9H6wx8QtxVB1V5L3/NZiSFBHZT1GOoaalLvW9KvU eH6EbnTomGgPsHVC7gdNeDwCI/qJo7U7iCwgLcbj+9tLulijayueWodGbm2zXyDn W1yStn7SMRR3lB3kY2FC1GnBqa/2vmsEfKxPr0HZATUnoVVv1bwOa2dGThmC9lQ3 ULCJz7s8n9ELMcgaeMIyVf9P79kCDqMC0Mp8MEPXvUMPL5XiMh5fVBc/wRIg8BI5 KEMEcnba9qgSlqlWJ7LGdc8sKYMj4aG9ca5VJnLLKBUw22kVFEz5TAIADeg+UPfw /Z8xFhCCx4rZVSqC4cgW =EMtG -----END PGP SIGNATURE----- --Apple-Mail=_E1A310D5-E2E5-4A5C-BC80-4BEA56058EDA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A26C4B8A-DD67-4F57-9E26-3DEADE7C82F1>