From owner-trustedbsd-cvs@FreeBSD.ORG Sun Jan 21 22:39:03 2007 Return-Path: X-Original-To: trustedbsd-cvs@freebsd.org Delivered-To: trustedbsd-cvs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5F3B916A408 for ; Sun, 21 Jan 2007 22:39:03 +0000 (UTC) (envelope-from owner-perforce@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id CDE1A13C44B for ; Sun, 21 Jan 2007 22:39:02 +0000 (UTC) (envelope-from owner-perforce@freebsd.org) Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by cyrus.watson.org (Postfix) with ESMTP id DC7FE4783C for ; Sun, 21 Jan 2007 17:39:00 -0500 (EST) Received: from hub.freebsd.org (hub.freebsd.org [69.147.83.54]) by mx2.freebsd.org (Postfix) with ESMTP id 496B455930; Sun, 21 Jan 2007 22:33:32 +0000 (GMT) (envelope-from owner-perforce@freebsd.org) Received: by hub.freebsd.org (Postfix, from userid 32767) id 1AEA516A41F; Sun, 21 Jan 2007 22:33:32 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E449116A403 for ; Sun, 21 Jan 2007 22:33:31 +0000 (UTC) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 520D013C4D1 for ; Sun, 21 Jan 2007 22:33:30 +0000 (UTC) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l0LMXTjo062418 for ; Sun, 21 Jan 2007 22:33:29 GMT (envelope-from millert@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l0LMXTgK062409 for perforce@freebsd.org; Sun, 21 Jan 2007 22:33:29 GMT (envelope-from millert@freebsd.org) Date: Sun, 21 Jan 2007 22:33:29 GMT Message-Id: <200701212233.l0LMXTgK062409@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to millert@freebsd.org using -f From: Todd Miller To: Perforce Change Reviews Cc: Subject: PERFORCE change 113280 for review X-BeenThere: trustedbsd-cvs@FreeBSD.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: TrustedBSD CVS and Perforce commit message list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jan 2007 22:39:03 -0000 http://perforce.freebsd.org/chv.cgi?CH=113280 Change 113280 by millert@millert_macbook on 2007/01/21 22:32:55 In __mac_mount(), if the copyinstr() fails jump to out1 instead of just returning--we need the vnode_put() and nameidone() calls for proper cleanup Affected files ... .. //depot/projects/trustedbsd/sedarwin8/darwin/xnu/bsd/vfs/vfs_syscalls.c#19 edit Differences ... ==== //depot/projects/trustedbsd/sedarwin8/darwin/xnu/bsd/vfs/vfs_syscalls.c#19 (text+ko) ==== @@ -248,7 +248,7 @@ error = copyinstr(uap->type, fstypename, MFSNAMELEN, &dummy); if (error) - return (error); + goto out1; if (uap->flags & MNT_UPDATE) { if ((vp->v_flag & VROOT) == 0) {