From owner-freebsd-questions@FreeBSD.ORG  Sun Jun 14 23:55:22 2015
Return-Path: <owner-freebsd-questions@FreeBSD.ORG>
Delivered-To: freebsd-questions@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5180BFD1
 for <freebsd-questions@hub.freebsd.org>; Sun, 14 Jun 2015 23:55:22 +0000 (UTC)
 (envelope-from freebsd@edvax.de)
Received: from mx02.qsc.de (mx02.qsc.de [213.148.130.14])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 11757909
 for <freebsd-questions@freebsd.org>; Sun, 14 Jun 2015 23:55:21 +0000 (UTC)
 (envelope-from freebsd@edvax.de)
Received: from r56.edvax.de (port-92-195-111-193.dynamic.qsc.de
 [92.195.111.193])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx02.qsc.de (Postfix) with ESMTPS id E59DF24CB8;
 Mon, 15 Jun 2015 01:55:17 +0200 (CEST)
Received: from r56.edvax.de (localhost [127.0.0.1])
 by r56.edvax.de (8.14.5/8.14.5) with SMTP id t5ENtGPq002079;
 Mon, 15 Jun 2015 01:55:17 +0200 (CEST)
 (envelope-from freebsd@edvax.de)
Date: Mon, 15 Jun 2015 01:55:16 +0200
From: Polytropon <freebsd@edvax.de>
To: "Lt. Commander" <listmgr@antennex.com>
Cc: <freebsd-questions@freebsd.org>
Subject: Re: Script question
Message-Id: <20150615015516.b3ea7633.freebsd@edvax.de>
In-Reply-To: <BAY404-EAS148D4B304BB066F07E84004CCB90@phx.gbl>
References: <BAY182-W89C2924F4BDF0D2BD3810DF4BB0@phx.gbl>
 <CA+g+BvjNv0PBOfmnWkzE26Tgqj6qZ-VKbHXMpuB8gak69G_T2g@mail.gmail.com>
 <BAY404-EAS263BBC0728E6171BD47A4AECCBA0@phx.gbl>
 <557B8484.9060405@gmail.com>
 <BAY182-W64842DB24FDD6D0F3A1854CCBA0@phx.gbl>
 <557C6DED.9070105@gmail.com>
 <BAY404-EAS148D4B304BB066F07E84004CCB90@phx.gbl>
Reply-To: Polytropon <freebsd@edvax.de>
Organization: EDVAX
X-Mailer: Sylpheed 3.1.1 (GTK+ 2.24.5; i386-portbld-freebsd8.2)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-questions@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: User questions <freebsd-questions.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-questions>, 
 <mailto:freebsd-questions-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-questions/>
List-Post: <mailto:freebsd-questions@freebsd.org>
List-Help: <mailto:freebsd-questions-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
 <mailto:freebsd-questions-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Jun 2015 23:55:22 -0000

On Sun, 14 Jun 2015 15:07:18 -0500, Lt. Commander wrote:
> I know it's ugly..... but places a list of the IPs in a file plus sends me a
> message with the same list.

Yes, it is ugly, but will probably work fine. :-)

Allow me a few comments:

> #!/bin/sh
> cd /var/log

Use absolute file names - you're accessing /var/log/maillog
only once.



> grep -i spam=YES maillog > spam.tmp && \

Don't write temporary files to /var/log, use /tmp instead.



> awk '{print $11}' spam.tmp | sort | uniq > spam-hi && \

You could omit the spam.tmp file and output the grep result
into awk directly, or maybe better, use awk's pattern matching.

Then you would have something like this:

grep -i "spam=YES" /var/log/maillog | awk '{print $11}' | sort | uniq |  sed -e 's/^.*=//' > /tmp/spam-ip.txt

Or if you want to omit the grep call:

awk '/spam=YES/ {print $11}' /var/log/maillog | sort | uniq | sed -e 's/^.*=//' > /tmp/spam-ip.txt

And then continue:

cat /tmp/spam-ip.txt >> /usr/samba/mail/envelope
cat /tmp/spam-ip.txt | mail -s "SPAM IPs...." us.navy@outlook.com

Finally, you can easily remove /tmp/spam-ip.txt.



The sort | uniq step is a very interesting and useful one.
Good idea! Have a look at "man sort" if sort -g fits your
needs better than the default, which I think is -n.



-- 
Polytropon
Magdeburg, Germany
Happy FreeBSD user since 4.0
Andra moi ennepe, Mousa, ...