From owner-svn-src-head@FreeBSD.ORG Wed Jun 12 18:32:02 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 53B23FB6; Wed, 12 Jun 2013 18:32:02 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-ee0-x231.google.com (mail-ee0-x231.google.com [IPv6:2a00:1450:4013:c00::231]) by mx1.freebsd.org (Postfix) with ESMTP id 3DBD5197F; Wed, 12 Jun 2013 18:32:01 +0000 (UTC) Received: by mail-ee0-f49.google.com with SMTP id b57so4533539eek.8 for ; Wed, 12 Jun 2013 11:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=3aYRGiT2BQ4TAzxiFiXT5CoxvokVzv6Ms2ziSDQ+NEU=; b=fzMJZ7EjbzfGtBejB4kFg2SldeOo//KqjhKsFehS6WEMkRQe4uAFURm7aV+I39N+mn NHjMDrGeM8e+IXoWrU0Ui7mUGMoX+o5Ad5Xss3559bTP0b546luBuBK+cBFnzLajMMfI zFfYJ8yx9ZoJY98biOFELapuHqeBa12eKNee5JDFl8RXTzPZV6KCGCyRWV7sdQkN3mxH IPE2AY70+clTdVjl2TxgSWZ0S5XNhoSE7vqBQJJzmyVFyGRZuQHalWIFEonemQy7LUCL I0If3hAflIo28Nj8aH4iyNhMHBXvWOM/fVi8nZxf6bHBpoXbvO8CQrmpDtxvd3wV6Hpc A4zQ== X-Received: by 10.14.9.136 with SMTP id 8mr22722594eet.37.1371061920211; Wed, 12 Jun 2013 11:32:00 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (mavhome.mavhome.dp.ua. [213.227.240.37]) by mx.google.com with ESMTPSA id y10sm38588729eev.3.2013.06.12.11.31.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 12 Jun 2013 11:31:59 -0700 (PDT) Sender: Alexander Motin Message-ID: <51B8BE9C.7070301@FreeBSD.org> Date: Wed, 12 Jun 2013 21:31:56 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130413 Thunderbird/17.0.5 MIME-Version: 1.0 To: Dimitry Andric Subject: Re: svn commit: r251654 - in head/sys: cam cam/scsi geom References: <201306121336.r5CDaKUF007665@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, Glen Barber , svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jun 2013 18:32:02 -0000 On 12.06.2013 21:29, Dimitry Andric wrote: > On Jun 12, 2013, at 15:36, Alexander Motin wrote: >> Author: mav >> Date: Wed Jun 12 13:36:20 2013 >> New Revision: 251654 >> URL: http://svnweb.freebsd.org/changeset/base/251654 >> >> Log: >> Make CAM return and GEOM DISK pass through new GEOM::lunid attribute. >> >> SPC-4 specification states that serial number may be property of device, >> but not a specific logical unit. People reported about FC storages using >> serial number in that way, making it unusable for purposes of LUN multipath >> detection. SPC-4 states that designators associated with logical unit from >> the VPD page 83h "Device Identification" should be used for that purpose. >> Report first of them in the new attribute in such preference order: NAA, >> EUI-64, T10 and SCSI name string. >> >> While there, make GEOM DISK properly report GEOM::ident in XML output also >> using d_getattr() method, if available. This fixes serial numbers reporting >> for SCSI disks in `geom disk list` output and confxml. >> >> Discussed with: gibbs, ken >> Sponsored by: iXsystems, Inc. >> MFC after: 2 weeks > > This prototype change breaks head: > > cc -O2 -pipe -DRESCUE -std=gnu99 -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wmissing-variable-declarations -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c /src/sbin/camcontrol/camcontrol.c > /src/sbin/camcontrol/camcontrol.c:6955:13: error: incompatible pointer types assigning to 'uint8_t *' (aka 'unsigned char *') from 'struct scsi_vpd_id_descriptor *' [-Werror,-Wincompatible-pointer-types] > item_addr = scsi_get_devid(item->device_id, > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Thank you for your reports, already testing fix. I'm sorry. -- Alexander Motin