From owner-trustedbsd-cvs@FreeBSD.ORG Sun Jan 21 22:39:10 2007 Return-Path: X-Original-To: trustedbsd-cvs@freebsd.org Delivered-To: trustedbsd-cvs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 83B4F16A401 for ; Sun, 21 Jan 2007 22:39:10 +0000 (UTC) (envelope-from owner-perforce@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id F37F413C468 for ; Sun, 21 Jan 2007 22:39:09 +0000 (UTC) (envelope-from owner-perforce@freebsd.org) Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by cyrus.watson.org (Postfix) with ESMTP id 11F9647FF1 for ; Sun, 21 Jan 2007 17:39:08 -0500 (EST) Received: from hub.freebsd.org (hub.freebsd.org [69.147.83.54]) by mx2.freebsd.org (Postfix) with ESMTP id C375292DAB; Sun, 21 Jan 2007 22:33:34 +0000 (GMT) (envelope-from owner-perforce@freebsd.org) Received: by hub.freebsd.org (Postfix, from userid 32767) id 66A0516A4C9; Sun, 21 Jan 2007 22:33:32 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EFEC116A40E for ; Sun, 21 Jan 2007 22:33:31 +0000 (UTC) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 92C0F13C4B7 for ; Sun, 21 Jan 2007 22:33:30 +0000 (UTC) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l0LMXUsn062428 for ; Sun, 21 Jan 2007 22:33:30 GMT (envelope-from millert@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l0LMXTm7062422 for perforce@freebsd.org; Sun, 21 Jan 2007 22:33:29 GMT (envelope-from millert@freebsd.org) Date: Sun, 21 Jan 2007 22:33:29 GMT Message-Id: <200701212233.l0LMXTm7062422@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to millert@freebsd.org using -f From: Todd Miller To: Perforce Change Reviews Cc: Subject: PERFORCE change 113281 for review X-BeenThere: trustedbsd-cvs@FreeBSD.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: TrustedBSD CVS and Perforce commit message list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jan 2007 22:39:10 -0000 http://perforce.freebsd.org/chv.cgi?CH=113281 Change 113281 by millert@millert_macbook on 2007/01/21 22:33:13 Add a missing vnode_put() if mac_mount_check_umount() denies access. Affected files ... .. //depot/projects/trustedbsd/sedarwin8/darwin/xnu/bsd/vfs/vfs_syscalls.c#20 edit Differences ... ==== //depot/projects/trustedbsd/sedarwin8/darwin/xnu/bsd/vfs/vfs_syscalls.c#20 (text+ko) ==== @@ -842,8 +842,10 @@ #ifdef MAC error = mac_mount_check_umount(vfs_context_ucred(&context), mp); - if (error != 0) + if (error != 0) { + vnode_put(vp); return (error); + } #endif /* * Must be the root of the filesystem