From owner-svn-src-head@freebsd.org Fri Mar 15 17:11:30 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25C1215272F7; Fri, 15 Mar 2019 17:11:30 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BDCF371B10; Fri, 15 Mar 2019 17:11:29 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 6F00D1DA50; Fri, 15 Mar 2019 17:11:29 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f51.google.com with SMTP id h6so7390240lfc.2; Fri, 15 Mar 2019 10:11:29 -0700 (PDT) X-Gm-Message-State: APjAAAV8zYXRcrpz/+3UcG9RLdxZwBs0GbFEE7LWyIA2FXn9YZDR8msM ycU9giz8j/8guLZ9+qqOZ1KuQOTEWlsQsvmHEC0= X-Google-Smtp-Source: APXvYqw1RNbdjt5XoeeUlkNQJgnHw2XfcRvT7q2vbP8SrUAzhM4FBr9xKOYApTBe0WLMZKXLlHQJMeaEOhzgmiz/W7I= X-Received: by 2002:ac2:424e:: with SMTP id m14mr541859lfl.4.1552669887873; Fri, 15 Mar 2019 10:11:27 -0700 (PDT) MIME-Version: 1.0 References: <51089C2A-A135-445E-B733-02654C5F8B68@lists.zabbadoz.net> <201903151704.x2FH4URq031149@gndrsh.dnsmgr.net> In-Reply-To: <201903151704.x2FH4URq031149@gndrsh.dnsmgr.net> From: Kyle Evans Date: Fri, 15 Mar 2019 12:11:14 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r345151 - head/sys/net To: "Rodney W. Grimes" Cc: "Bjoern A. Zeeb" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: BDCF371B10 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 17:11:30 -0000 On Fri, Mar 15, 2019 at 12:04 PM Rodney W. Grimes wrote: > > > On 14 Mar 2019, at 19:48, Kyle Evans wrote: > > > > > Author: kevans > > > Date: Thu Mar 14 19:48:43 2019 > > > New Revision: 345151 > > > URL: https://svnweb.freebsd.org/changeset/base/345151 > > > > > > Log: > > > ether_fakeaddr: Use 'b' 's' 'd' for the prefix > > > > > > This has the advantage of being obvious to sniff out the designated > > > prefix > > > by eye and it has all the right bits set. Comment stolen from ffec. > > > > > > I've removed bryanv@'s pending question of using the FreeBSD OUI > > > range -- > > > no one has followed up on this with a definitive action, and there's > > > no > > > particular reason to shoot for it and the administrative overhead > > > that comes > > > with deciding exactly how to use it. > > > > Yay. iflib_gen_mac() has already thought kind-of similar and just took > > the entire(?) FreeBSD space for doing the same. That code should be > > merged as well. > > > > Bhyve is using a good chunk from the FreeBSD allocation; see > > sys/net/ieee_oui.h also for allocation guidelines (if I don?t > > misremember). > > > > The fact that it might need figuring out should not prevent us from > > doing it right .. the third time .. maybe .. this time? > > > > epair(4) is yet another one of the cloned interfaces which does magic > > for the ethernet addresses, not sure what else. > > Yes yes yes please! Can we get the OUI assigning code collapsed to > one place, though it well need to come in dependent on a complex set > of options, or perhaps just INET and/or INET6 should drag it in. > For you and anyone else that wants to participate, I opened up https://reviews.freebsd.org/D19587 for this effort last night-ish to hash out the details. Thanks, Kyle Evans