From owner-svn-ports-head@freebsd.org Wed Jul 31 08:36:42 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5E382B877C; Wed, 31 Jul 2019 08:36:42 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3E02393702; Wed, 31 Jul 2019 08:36:42 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 112FF37AB; Wed, 31 Jul 2019 08:36:42 +0000 (UTC) Date: Wed, 31 Jul 2019 08:36:42 +0000 From: Alexey Dokuchaev To: Jan Beich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r507691 - head/audio/alsa-plugins Message-ID: <20190731083641.GA98868@FreeBSD.org> References: <201907310237.x6V2bZgf059599@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201907310237.x6V2bZgf059599@repo.freebsd.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 3E02393702 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jul 2019 08:36:42 -0000 On Wed, Jul 31, 2019 at 02:37:35AM +0000, Jan Beich wrote: > New Revision: 507691 > URL: https://svnweb.freebsd.org/changeset/ports/507691 > > Log: > audio/alsa-plugins: drop unnecessary newline after r505839 > > - Wasn't approved i.e., explicitly requested to not add it > - portlint style frequently changes and isn't mandatory to follow Portlint was broken in one of the recent versions when it started to offer a newline between USES and e.g. GNU_CONFIGURE while there's no need for it at all. Unfortunately, many people blindly follow its advice which results in needless repochurn and Makefile formatting pessimization. :-( ./danfe