From owner-cvs-all@FreeBSD.ORG  Wed Apr 14 05:56:42 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BE9B716A4CE; Wed, 14 Apr 2004 05:56:42 -0700 (PDT)
Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 07E8A43D4C; Wed, 14 Apr 2004 05:56:42 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au
	[61.8.0.87])i3ECub5v005157;	Wed, 14 Apr 2004 22:56:37 +1000
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i3ECuYsg017144;	Wed, 14 Apr 2004 22:56:35 +1000
Date: Wed, 14 Apr 2004 22:56:33 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: =?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?= <des@des.no>
In-Reply-To: <xzpisg292tp.fsf@dwp.des.no>
Message-ID: <20040414224330.Q3533@gamplex.bde.org>
References: <200404140040.i3E0esil061104@repoman.freebsd.org>
 <20040414021526.GB63832@elvis.mu.org> <20040414093706.GB65853@regency.nsu.ru>
 <xzpisg292tp.fsf@dwp.des.no>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=X-UNKNOWN
Content-Transfer-Encoding: QUOTED-PRINTABLE
cc: Alexey Dokuchaev <danfe@nsu.ru>
cc: src-committers@freebsd.org
cc: cvs-src@freebsd.org
cc: Alfred Perlstein <alfred@freebsd.org>
cc: cvs-all@freebsd.org
cc: Tim Kientzle <kientzle@freebsd.org>
Subject: Re: cvs commit: src/usr.bin/tar bsdtar.c bsdtar.h write.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 12:56:42 -0000

On Wed, 14 Apr 2004, [iso-8859-1] Dag-Erling Sm=F8rgrav wrote:

> Alexey Dokuchaev <danfe@nsu.ru> writes:
> > On Tue, Apr 13, 2004 at 07:15:26PM -0700, Alfred Perlstein wrote:
> > > While I applaud the effort here, it is a major violation of C
> > > POLA to have compilable code within a header file.
> > Seconded.  Please keep *.h code-free.
>
> What are you guys all smoking?  Did you even look at the file in
> question?

The file does claim to do bad things in a comment:

% /* Data for exclusion/inclusion handling: defined in matching.c */
% struct matching;
% struct links_entry;
% struct archive_dir_entry;

Contrary to the comment, there is no data definition or even data
declaration here,  There are only bogus unsorted forward declarations
here.  These style bugs are not new; they were in rev.1.1.

Bruce