From owner-freebsd-current@freebsd.org  Thu Nov 16 20:48:19 2017
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3E01ADE8B60
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Thu, 16 Nov 2017 20:48:19 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1B10E69BC2;
 Thu, 16 Nov 2017 20:48:18 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 976C010A8BE;
 Thu, 16 Nov 2017 15:48:11 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
Cc: Mateusz Guzik <mjg@freebsd.org>,
 FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: Breakage with
 sys.kern.ptrace_test.{ptrace__parent_sees_exit_after_child_debugger,
 parent_sees_exit_after_unrelated_debugger} after r325719:325721
Date: Thu, 16 Nov 2017 12:48:08 -0800
Message-ID: <3305084.Q9yLTkYrJQ@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; )
In-Reply-To: <7567DDF3-6E53-455F-B25E-AE2082F74F40@gmail.com>
References: <7567DDF3-6E53-455F-B25E-AE2082F74F40@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Thu, 16 Nov 2017 15:48:11 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Nov 2017 20:48:19 -0000

On Thursday, November 16, 2017 09:07:56 AM Ngie Cooper wrote:
> Hi Mateusz,
> 	Per Jenkins, these two tests are broken after r325719:325721: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/4987/ <https://ci.freebsd.org/job/FreeBSD-head-amd64-test/4987/> .
> Thanks,
> -Ngie

It is probably the first commit.  Previously, the kern.proc.<pid> sysctl
would fail for zombies, so these tests poll that sysctl waiting for it to
fail to determine when a process has become a zombie.  I think the first
commit broke this as the sysctl now works for zombies so the tests hang
forever.  I could fix the tests to check for the status in the kinfo_proc.
I've no idea if there are other programs aside from tests that depend on
this behavior that are also broken though.  I feel like I copied that
approach from some other bit of code when writing these tests.

-- 
John Baldwin