From owner-freebsd-current@FreeBSD.ORG  Mon Jul 11 21:38:22 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3DC3A1065672;
	Mon, 11 Jul 2011 21:38:22 +0000 (UTC)
	(envelope-from lacombar@gmail.com)
Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com
	[74.125.83.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 01A568FC0C;
	Mon, 11 Jul 2011 21:38:21 +0000 (UTC)
Received: by pvg11 with SMTP id 11so4204249pvg.13
	for <multiple recipients>; Mon, 11 Jul 2011 14:38:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=6RcsUVCy9rUjpK8kfpOXi6pH8A4mZF85yKApD3bR6l4=;
	b=eTi2eXGWAAVpS6h60SO1VgCHXdGN2eJ309w+UZbbCghpULn6heWZBkkwkkA7G+pXjZ
	h9DMXTTjGvJqrBbbs/cFI2B2UVUT7vx8APRkNwmsfurUAfSLGrNCoXfboP1XkKpEh3Hp
	U4iAVlMCWYBoLXuhJHf0MQjlVzFzSuAmxk27Y=
MIME-Version: 1.0
Received: by 10.68.32.165 with SMTP id k5mr7923900pbi.273.1310420301441; Mon,
	11 Jul 2011 14:38:21 -0700 (PDT)
Received: by 10.68.49.42 with HTTP; Mon, 11 Jul 2011 14:38:21 -0700 (PDT)
In-Reply-To: <20110711204049.GA98996@troutmask.apl.washington.edu>
References: <20110706162811.GA68436@troutmask.apl.washington.edu>
	<CACqU3MVLr5VXRovs1uV+zHazJi2rrjE9Sp3XzsCPJ0Un06pmDQ@mail.gmail.com>
	<20110706193636.GA69550@troutmask.apl.washington.edu>
	<4E14CCE5.4050906@zedat.fu-berlin.de>
	<CAJ-VmomNcbGggbQePi2kBC7uRJm3BenMNKjsqkH5hFLqudsCvg@mail.gmail.com>
	<20110707015151.GB71966@troutmask.apl.washington.edu>
	<CAJ-VmongFDGi0amaqod5_NBQcH+guA5QMXtttCjTD=ccB==+UQ@mail.gmail.com>
	<CACqU3MVv-YpttXWYnvraR3PT9nh9P1AWMxoXJPevMRhNt4cr5g@mail.gmail.com>
	<CAJ-VmokC+pzoB_x31UGSNt2oRLXfzOK9aXhCMR3FBm7iGEyaAQ@mail.gmail.com>
	<CACqU3MXVdQfYEBNb9OLnt7CudiBRdvaq3Cd_HXBC8ZrCpmRFvg@mail.gmail.com>
	<20110711204049.GA98996@troutmask.apl.washington.edu>
Date: Mon, 11 Jul 2011 17:38:21 -0400
Message-ID: <CACqU3MUZC5GO-_oSkE3PFk3XQPWHn8XyD7XsG5xamD8hjjHh4w@mail.gmail.com>
From: Arnaud Lacombe <lacombar@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Adrian Chadd <adrian@freebsd.org>,
	FreeBSD Current <freebsd-current@freebsd.org>, "Hartmann,
	O." <ohartman@zedat.fu-berlin.de>,
	arrowdodger <6yearold@gmail.com>, freebsd-questions@freebsd.org
Subject: Re: Heavy I/O blocks FreeBSD box for several seconds
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jul 2011 21:38:22 -0000

Hi,

On Mon, Jul 11, 2011 at 4:40 PM, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> On Mon, Jul 11, 2011 at 04:33:44PM -0400, Arnaud Lacombe wrote:
>>
>> For the record, I would like to see enforced public review for _every_
>> patch *before* it is checked in, as a strong rule. gcc system is
>> particularly interesting. But it is not likely to happen in FreeBSD
>> where FreeBSD committers are clearly more free than other at
>> checking-in un-publicly-reviewed stuff (especially _bad_ stuff).
>>
>> This would of course apply even to long-time committers, no matter how
>> it hurt their ego (which I definitively do not care about).
>>
>
> As a long time GCC committer, I think that you have grossly
> over-simplified the GCC review process and how a submitted
> patch is approved for committing.
>
Yes.

 - Arnaud