From owner-p4-projects@FreeBSD.ORG  Thu Jan 24 11:36:22 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5779016A41A; Thu, 24 Jan 2008 11:36:22 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1CB9016A418
	for <perforce@freebsd.org>; Thu, 24 Jan 2008 11:36:22 +0000 (UTC)
	(envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id EDC5A13C46B
	for <perforce@freebsd.org>; Thu, 24 Jan 2008 11:36:21 +0000 (UTC)
	(envelope-from sam@errno.com)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m0OBQ9uh023688
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 24 Jan 2008 03:26:11 -0800 (PST) (envelope-from sam@errno.com)
Message-ID: <479875D1.3080205@errno.com>
Date: Thu, 24 Jan 2008 03:26:09 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20071125)
MIME-Version: 1.0
To: Sepherosa Ziehau <sephe@freebsd.org>
References: <200801240705.m0O75Q4o085638@repoman.freebsd.org>
In-Reply-To: <200801240705.m0O75Q4o085638@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC--Metrics: ebb.errno.com; whitelist
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 133975 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jan 2008 11:36:22 -0000

Sepherosa Ziehau wrote:
> http://perforce.freebsd.org/chv.cgi?CH=133975
>
> Change 133975 by sephe@sephe_zealot:sam_wifi on 2008/01/24 07:04:31
>
> 	Duplicate the ieee80211_{scan_result,sta_info} structure and add
> 	{isr,isi}_capinfo2 at the end of the structure.  Rename old
> 	structure to structure_name_v1.
> 	
>   
If you look in ieee80211_ioctl.c you'll see similar logic for handling a 
compat change.  What I typically do is change the public structure 
definition and keep the old/compat def only in the place where it is 
used.  This insures noone will write user code that uses the old api.

    Sam