Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Aug 2023 14:29:56 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 273039] astro/starfetch: Update to 0.0.4
Message-ID:  <bug-273039-7788-vfjF6K70ea@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-273039-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-273039-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273039

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org
           Assignee|ports-bugs@FreeBSD.org      |fuz@FreeBSD.org
             Status|New                         |In Progress

--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Instead of ${FIND} ... -exec ${RM} {} \;, you can filter files during
COPYTREE_SHARE.  I'll amend the patch to do this for you.

There is no need to strip the binary again.  ${INSTALL_PROGRAM} already str=
ips
programs it installs for you.

I'll also go ahead and merge post-install into do-install.  There does not =
seem
to be a reason to have both.

Lastly, your compiler invocation should obey all of CPPFLAGS, CXXFLAGS, and
LDFLAGS.  I'll go ahead and edit the missing ones in.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-273039-7788-vfjF6K70ea>