From owner-cvs-all@FreeBSD.ORG  Mon Jan 23 19:28:36 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2D32616A41F;
	Mon, 23 Jan 2006 19:28:36 +0000 (GMT)
	(envelope-from trhodes@FreeBSD.org)
Received: from pittgoth.com (ns1.pittgoth.com [216.38.206.188])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B0CAE43D49;
	Mon, 23 Jan 2006 19:28:32 +0000 (GMT)
	(envelope-from trhodes@FreeBSD.org)
Received: from localhost (ip68-105-180-11.dc.dc.cox.net [68.105.180.11])
	(authenticated bits=0)
	by pittgoth.com (8.13.4/8.13.4) with ESMTP id k0NK5sph016450
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Mon, 23 Jan 2006 15:05:54 -0500 (EST)
	(envelope-from trhodes@FreeBSD.org)
Date: Mon, 23 Jan 2006 14:28:22 -0500
From: Tom Rhodes <trhodes@FreeBSD.org>
To: John Baldwin <jhb@FreeBSD.org>
Message-Id: <20060123142822.1be78fcb.trhodes@FreeBSD.org>
In-Reply-To: <200601231356.18292.jhb@freebsd.org>
References: <200601211210.k0LCAXYl069896@repoman.freebsd.org>
	<200601231356.18292.jhb@freebsd.org>
X-Mailer: Sylpheed version 1.0.5 (GTK+ 1.2.10; i386-portbld-freebsd7.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/nfsserver nfs_serv.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2006 19:28:36 -0000

On Mon, 23 Jan 2006 13:56:16 -0500
John Baldwin <jhb@FreeBSD.org> wrote:

> On Saturday 21 January 2006 07:10, Tom Rhodes wrote:
> > trhodes     2006-01-21 12:10:33 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/nfsserver        nfs_serv.c
> >   Log:
> >   Remove some dead code.
> >
> >   Found with:     Coverity Prevent(tm)
> 
> Are you going to revert this change given the replies?

Oh, I didn't interpret the comments as "this is wrong please
back it out."  I just seen replies, both public and private,
complaining about the indentation.  They went like:

stefanf: "Are you sure this is correct?"
  rwatson: "code is a mess in NFS"

ru: quoting the code "bad indentation"
njl quoting the code "bad indentation"

rees (NFSv4 guy): "looks fine to me"

If you, or anyone else for that matter actually wants it
reverted, I'll do that.  I'm not in the mood to argue
with people today, or ever.  :)

-- 
Tom Rhodes