Date: Fri, 8 Jun 2012 08:38:10 +0400 From: Ruslan Ermilov <ru@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: ports@freebsd.org Subject: conditional config is skipped for optionsNG'ified ports Message-ID: <20120608043810.GA23079@lo0.su>
next in thread | raw e-mail | index | archive | help
Hi, I've noticed (while portupgrading www/nginx-devel) that despite of the new options set it doesn't provide me with the configuration diaglog. This is because _OPTIONS_OK is set when OPTIONS isn't, and the latter is always true for ports that have been converted. : $ pwd && make -V PKGNAME -V _OPTIONS_READ -V _FILE_COMPLETE_OPTIONS_LIST -V _OPTIONS_OK : /usr/ports/www/nginx-devel : nginx-devel-1.3.1 : nginx-devel-1.3.0 : : yes The following condition in bsd.port.mk should be taught about optionsNG to fix the issue: %%% ################################################################ # # Do preliminary work to detect if we need to run the config # target or not. # ################################################################ .if (!defined(OPTIONS) || defined(CONFIG_DONE_${UNIQUENAME:U}) || \ defined(PACKAGE_BUILDING) || defined(BATCH)) _OPTIONS_OK=yes .endif %%% Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120608043810.GA23079>