From owner-p4-projects@FreeBSD.ORG  Sun Jul 22 17:47:04 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 95A3F16A419; Sun, 22 Jul 2007 17:47:04 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3F25416A417
	for <perforce@FreeBSD.org>; Sun, 22 Jul 2007 17:47:04 +0000 (UTC)
	(envelope-from rpaulo@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 3476D13C428
	for <perforce@FreeBSD.org>; Sun, 22 Jul 2007 17:47:04 +0000 (UTC)
	(envelope-from rpaulo@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l6MHl4x5013586
	for <perforce@FreeBSD.org>; Sun, 22 Jul 2007 17:47:04 GMT
	(envelope-from rpaulo@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l6MHl3Y3013582
	for perforce@freebsd.org; Sun, 22 Jul 2007 17:47:03 GMT
	(envelope-from rpaulo@FreeBSD.org)
Date: Sun, 22 Jul 2007 17:47:03 GMT
Message-Id: <200707221747.l6MHl3Y3013582@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	rpaulo@FreeBSD.org using -f
From: Rui Paulo <rpaulo@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 123917 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Jul 2007 17:47:04 -0000

http://perforce.freebsd.org/chv.cgi?CH=123917

Change 123917 by rpaulo@rpaulo_epsilon on 2007/07/22 17:46:35

	Stop creating a child node in the sysctl hw tree and start using
	the device tree provided by newbus.

Affected files ...

.. //depot/projects/soc2007/rpaulo-macbook/dev/backlight/backlight.c#10 edit

Differences ...

==== //depot/projects/soc2007/rpaulo-macbook/dev/backlight/backlight.c#10 (text+ko) ====

@@ -23,7 +23,7 @@
  * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  * POSSIBILITY OF SUCH DAMAGE.
  *
- * $P4: //depot/projects/soc2007/rpaulo-macbook/dev/backlight/backlight.c#9 $
+ * $P4: //depot/projects/soc2007/rpaulo-macbook/dev/backlight/backlight.c#10 $
  *
  */
 
@@ -175,21 +175,14 @@
 	if (error)
 		return (error);
 
-	sysctl_ctx_init(&sc->sc_sysctl_ctx);
-	sc->sc_sysctl_tree = SYSCTL_ADD_NODE(&sc->sc_sysctl_ctx,
-	    SYSCTL_STATIC_CHILDREN(_hw),
-	    OID_AUTO,
-	    device_get_name(dev),
-	    CTLFLAG_RD, 0, "");
-
-	SYSCTL_ADD_PROC(&sc->sc_sysctl_ctx,
-	    SYSCTL_CHILDREN(sc->sc_sysctl_tree),
+	SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev),
+	    SYSCTL_CHILDREN(device_get_sysctl_tree(dev)),
 	    OID_AUTO, "enable", CTLTYPE_INT | CTLFLAG_RW,
 	    sc, 0, model->bm_enable, "I",
 	    "Turn the backlight on/off");
 
-	SYSCTL_ADD_PROC(&sc->sc_sysctl_ctx,
-	    SYSCTL_CHILDREN(sc->sc_sysctl_tree),
+	SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev),
+	    SYSCTL_CHILDREN(device_get_sysctl_tree(dev)),
 	    OID_AUTO, "level", CTLTYPE_INT | CTLFLAG_RW,
 	    sc, 0, model->bm_level, "I",
 	    "Brightness level of the backlight");
@@ -200,10 +193,6 @@
 static int
 backlight_detach(device_t dev)
 {
-	struct backlight_softc *sc = device_get_softc(dev);
-
-	sysctl_ctx_free(&sc->sc_sysctl_ctx);
-
 	return (0);
 }