From owner-freebsd-bugs@FreeBSD.ORG  Sun Apr 20 03:40:15 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C4B2737B404
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 20 Apr 2003 03:40:14 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9FFE343FBD
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 20 Apr 2003 03:40:13 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h3KAeDUp036800
	for <freebsd-bugs@freefall.freebsd.org>;
	Sun, 20 Apr 2003 03:40:13 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h3KAeDRA036799;
	Sun, 20 Apr 2003 03:40:13 -0700 (PDT)
Date: Sun, 20 Apr 2003 03:40:13 -0700 (PDT)
Message-Id: <200304201040.h3KAeDRA036799@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Peter van Dijk <peter@dataloss.nl>
Subject: Re: bin/51151: du hardlinkmatching is slow - fix included
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Peter van Dijk <peter@dataloss.nl>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Apr 2003 10:40:16 -0000

The following reply was made to PR bin/51151; it has been noted by GNATS.

From: Peter van Dijk <peter@dataloss.nl>
To: David Schultz <das@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: bin/51151: du hardlinkmatching is slow - fix included
Date: Sun, 20 Apr 2003 12:35:12 +0200

 On Sun, Apr 20, 2003 at 02:51:49AM -0700, David Schultz wrote:
 [snip]
 > In libc, there are hcreate(3) and friends, which work nicely except
 > for their limitation of one hash table per module.  That shouldn't
 > be an issue here.  Alternatively, you could roll your own easily
 > enough.  Here's some pseudocode using chaining:
 
 I tried hcreate but it failed miserably. I may investigate that some
 more (it seemed to misbehave on my input) and send-pr about it.
 
 I intend to roll my own with open addressing indeed.
 
 > 	hval = hash(ino, dev);
 > 	for (p = table[hval]; p != NULL; p = p->next)
 > 		if (p->ino == ino && p->dev == dev)
 > 			return (1);
 > 	p = malloc(sizeof(hashent));
 > 	p->next = table[hval];
 > 	p->ino = ino;
 > 	p->dev = dev;
 > 	talbe[hval] = p;
 
 Indeed, it shouldn't be hard :)
 
 Greetz, Peter
 -- 
 peter@dataloss.nl | ~ we care a lot: about the war we're fighting
 www.dataloss.nl   |  - gee that looks like fun! (Faith no more)
 UnderNet/#clue    | 
                   |       iraqbodycount.net: min 1878, max 2325