From owner-freebsd-current@FreeBSD.ORG  Fri Mar 13 04:56:14 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EEC48106564A;
	Fri, 13 Mar 2009 04:56:14 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from mail-bw0-f164.google.com (mail-bw0-f164.google.com
	[209.85.218.164])
	by mx1.freebsd.org (Postfix) with ESMTP id DF74E8FC17;
	Fri, 13 Mar 2009 04:56:13 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: by bwz8 with SMTP id 8so2421499bwz.43
	for <multiple recipients>; Thu, 12 Mar 2009 21:56:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:sender:received:in-reply-to
	:references:date:x-google-sender-auth:message-id:subject:from:to:cc
	:content-type:content-transfer-encoding;
	bh=Mah/MoTCu0ZEWs1UEqxtSSXb54kds/zAmxzIWYOhQ7I=;
	b=is1clB1B3RXmP+k6vyjA0V+xFyEyJdH84MWyR5fqqEK80LtvDU+YyqqVKibraDoRWh
	zUnfMttSDhGxs/KlxOL85do+cu41jpecmiPqBIbF5564x/r/MR1OgJUdOV1egRArCSTH
	z7YOqcd2aFPo02gC5XjuTJVaiU8bSm5XdlumI=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	b=np9LRLTN35RncmFWB0emQuYrOIyLklOwrfQeLtWnYdZHWrrbKGLDc9qg3RRi8HBgbp
	KHzIpd0nyoFqL6AhX6omV/IkegvU/yvkn7wnGJ7llyNFmqZ01uT6rdW9WQn4VwRxxWzn
	Ii3kd7PdUe3oNhBzTCrZ9q81bw/j2xF3fMVkA=
MIME-Version: 1.0
Sender: asmrookie@gmail.com
Received: by 10.103.52.7 with SMTP id e7mr413205muk.115.1236920172522; Thu, 12 
	Mar 2009 21:56:12 -0700 (PDT)
In-Reply-To: <29C8FA04-D5B1-49B7-ACF0-4185537367B0@baldwin.cx>
References: <20090312175345.Y80227@rust.salford.ac.uk>
	<20090312191333.GA97342@hyperion.scode.org>
	<49B97617.8010709@freebsd.org> <86r6124f2v.fsf@gmail.com>
	<3bbf2fe10903122035i20b2767cod2322c39c6f850ee@mail.gmail.com>
	<29C8FA04-D5B1-49B7-ACF0-4185537367B0@baldwin.cx>
Date: Fri, 13 Mar 2009 05:56:12 +0100
X-Google-Sender-Auth: 38d4ffce119b0362
Message-ID: <3bbf2fe10903122156u650417f0s5c49b68bdf4ffa07@mail.gmail.com>
From: Attilio Rao <attilio@freebsd.org>
To: John Baldwin <john@baldwin.cx>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Pawel Jakub Dawidek <pjd@freebsd.org>,
	"freebsd-current@freebsd.org" <freebsd-current@freebsd.org>,
	Tim Kientzle <kientzle@freebsd.org>,
	Mark Powell <M.S.Powell@salford.ac.uk>, Anonymous <swell.k@gmail.com>,
	Peter Schuller <peter.schuller@infidyne.com>
Subject: Re: repeatable ZFS panic: share->excl
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Mar 2009 04:56:15 -0000

2009/3/13, John Baldwin <john@baldwin.cx>:
> This is similar to the patch I've asked lulf@ to test except that it is
> longer and I fix a bug where zfs_lookup() can leak a vnode lock if the
> access check fails. :-)  The last one I sent to lulf@ is at
> www.FreeBSD.org/~jhb/patches/zfs_ea.patch.

I really thought zfs_lookup() was returning the lock held as a feature
assming no LOCKLEAF.
Is that a bug instead?

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein