From owner-svn-src-all@FreeBSD.ORG Tue Nov 4 20:16:14 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from hammer.pct.niksun.com (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by hub.freebsd.org (Postfix) with ESMTP id EF7E6F13; Tue, 4 Nov 2014 20:16:13 +0000 (UTC) Message-ID: <5459340D.2030605@FreeBSD.org> Date: Tue, 04 Nov 2014 15:16:13 -0500 From: Jung-uk Kim User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Dmitry Morozovsky , Glen Barber Subject: Re: svn commit: r274095 - head/release References: <201411041724.sA4HOEGD098532@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Nov 2014 20:16:14 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/04/2014 14:45, Dmitry Morozovsky wrote: > On Tue, 4 Nov 2014, Glen Barber wrote: > >> Author: gjb Date: Tue Nov 4 17:24:13 2014 New Revision: 274095 >> URL: https://svnweb.freebsd.org/changeset/base/274095 >> >> Log: Fix VOLUME_LABEL when BRANCH contains non-alpha characters, >> in particular '-' and '.'. > > [snip] > > By the way, what are original reasons to not allow '-' and '_' in > volume names? > > It looks a bit inconsistent with other file systems volume > labels... AFAIK, it is an ISO9660 limitation, i.e., it must be "d-characters". http://wiki.osdev.org/ISO_9660#String_format http://wiki.osdev.org/ISO_9660#The_Primary_Volume_Descriptor In fact, makefs(8) enforces this rule. https://svnweb.freebsd.org/base/head/usr.sbin/makefs/cd9660.c?annotate=253707#l343 https://svnweb.freebsd.org/base/head/usr.sbin/makefs/cd9660.c?annotate=253707#l270 https://svnweb.freebsd.org/base/head/usr.sbin/makefs/cd9660/cd9660_strings.c?annotate=219956#l57 Jung-uk Kim -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUWTQNAAoJEHyflib82/FGwv0H/1P+TbNgugx5H6zkb/FL9j1/ wbP4vqlwV/L+kxmtZgeaa6Oe42ki9o0N6wXyDuran/aQISsXnz8AastSqwWDUVTA HWVWauJgdVWlJ4PKGxbX1Dkn4fuIVqxjLzVOt3U7Jw18chsNlF2B21vmrFoBnqAj EpOnKKCHyJ6oBlWamFawMyFILI9UgrLGGsrxqnNbemU5LVW4cLSloTu2rJUfRhkp N/jITXIKrcaZ3se2Sha11Ue0rjo6d88wyqjJfNSfl4ipKMKvHLkV+8wXRZ6hc1G/ Jb5C+fvlvGIj9Lxyo/h24LpjOfANEvrLdsFd4bLY+NEOe5nlVg/cbAJyrq64b7M= =GK65 -----END PGP SIGNATURE-----