From nobody Tue May 3 20:08:29 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7338C1AABD4C; Tue, 3 May 2022 20:08:33 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kt9y774cmz4dby; Tue, 3 May 2022 20:08:31 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1651608510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N8DJ2/2pswCj0Nzl/E7wuol/w2MMJAPdvpmsscyChPY=; b=VqsQB3e10YAnrO1F5lkQInfZgVyMnl9vELgWkTn0QSQ/KfNO5PS73cr0Mmbg2eBJss9zEC nKZ1NrE0jXp3j1ohmcAgzEe8JTvEVVjxnm/0oLx+c3dku6N1vRsyrKl6gmFfY4sH5NL7E9 k5f0RowuDzwh/zV9/gdV9ficPPcnrsM= Received: from amy (lfbn-idf2-1-1209-45.w90-92.abo.wanadoo.fr [90.92.34.45]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 82d7e375 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 3 May 2022 20:08:30 +0000 (UTC) Date: Tue, 3 May 2022 22:08:29 +0200 From: Emmanuel Vadot To: Jan Beich Cc: Christoph Moench-Tegeder , Joseph Mingrone , Craig Leres , Christoph Moench-Tegeder , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 980444a82fbd - main - www/firefox: update to 100.0 (rc2) Message-Id: <20220503220829.e6077c4e739125a64e20b1ea@bidouilliste.com> In-Reply-To: References: <202204291458.23TEwiL4068411@gitrepo.freebsd.org> <58e45f7c-b79f-9f14-4df5-00617fee9ea4@freebsd.org> <05c2a241-5d32-24d9-c223-66aa9ca99b75@freebsd.org> <76d4fb65-b1df-2941-cc06-5ab23607a233@freebsd.org> <20220503094616.ad8309626972ab0c7d6c1cd9@bidouilliste.com> <4k26-hkiv-wny@FreeBSD.org> <86y1ziab1f.fsf@phe.ftfl.ca> <20220503175240.89a47079840b06ce1a6cc22a@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Kt9y774cmz4dby X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=VqsQB3e1; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-3.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; FREEFALL_USER(0.00)[manu]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bidouilliste.com:+]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; RCPT_COUNT_SEVEN(0.00)[8]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; MLMMJ_DEST(0.00)[dev-commits-ports-main,dev-commits-ports-all]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, 03 May 2022 18:53:23 +0200 Jan Beich wrote: > Emmanuel Vadot writes: > > > On Tue, 3 May 2022 17:45:14 +0200 > > Christoph Moench-Tegeder wrote: > > > >> ## Joseph Mingrone (jrm@FreeBSD.org): > >> > >> > Turning LTO off fixed the problem here. > >> > >> I just found out that turning LTO on breaks firefox for me, so that > >> settles that. I'll push that soon. > > > > That's good for now thanks but what about the futur ? > > Should we allow to have LTO turn on on port that uses both LLVM and > > Rust ? Because otherwise it will happen again when a new rust version > > if released and the llvm version isn't the same. > > - Known since https://cgit.freebsd.org/ports/commit/?id=b1c90afe23f9 > - Adhered previously in https://cgit.freebsd.org/ports/commit/?id=124261fa7deb > - Complicated by wasi-compiler-rt* split from llvm* packages > > Mozilla recommends its own Firefox builds due to LTO + PGO. FreeBSD is a > Tier3 (aka "patches welcome" and no CI), so disabling LTO will reduce > performance with no fallback binaries. Rebuilding Firefox locally isn't > a good proposition due to long build time (more with LTO), high memory > requirement (more with LTO), frequent updates to firefox and many of its > dependencies (harfbuzz, nss, ffmpeg, etc). > > I've enabled LTO by default a year ago to prevent dilapidation. Back then > when LTO was exposed there were numerious bug reports about broken build. I'm glad that it's known for a year and that no one tried to make a policy that will prevent this from even happening. What's the perf impact on disabling LTO on Firefox ? -- Emmanuel Vadot