From owner-svn-src-all@FreeBSD.ORG  Wed Jun 13 21:10:00 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C9AE71065673;
	Wed, 13 Jun 2012 21:10:00 +0000 (UTC) (envelope-from pjd@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [69.147.83.44])
	by mx1.freebsd.org (Postfix) with ESMTP id B0ED98FC12;
	Wed, 13 Jun 2012 21:10:00 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q5DLA0ep048994;
	Wed, 13 Jun 2012 21:10:00 GMT (envelope-from pjd@svn.freebsd.org)
Received: (from pjd@localhost)
	by svn.freebsd.org (8.14.4/8.14.4/Submit) id q5DLA0rb048990;
	Wed, 13 Jun 2012 21:10:00 GMT (envelope-from pjd@svn.freebsd.org)
Message-Id: <201206132110.q5DLA0rb048990@svn.freebsd.org>
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Date: Wed, 13 Jun 2012 21:10:00 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r237028 - head/sys/kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jun 2012 21:10:00 -0000

Author: pjd
Date: Wed Jun 13 21:10:00 2012
New Revision: 237028
URL: http://svn.freebsd.org/changeset/base/237028

Log:
  There is no need to set td->td_retval[0] to -1 on error.
  
  Confirmed by:	jhb
  MFC after:	1 month

Modified:
  head/sys/kern/vfs_syscalls.c

Modified: head/sys/kern/vfs_syscalls.c
==============================================================================
--- head/sys/kern/vfs_syscalls.c	Wed Jun 13 21:03:01 2012	(r237027)
+++ head/sys/kern/vfs_syscalls.c	Wed Jun 13 21:10:00 2012	(r237028)
@@ -1250,7 +1250,6 @@ bad_unlocked:
 	if (indx != -1)
 		fdclose(fdp, fp, indx, td);
 	fdrop(fp, td);
-	td->td_retval[0] = -1;
 	return (error);
 }