From owner-svn-ports-all@freebsd.org Sun Jun 19 12:20:52 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32F83A787D8; Sun, 19 Jun 2016 12:20:52 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0C2642656; Sun, 19 Jun 2016 12:20:51 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from anthias (vie-91-186-158-235.dsl.sil.at [91.186.158.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ainaz.pair.com (Postfix) with ESMTPSA id 63E963F427; Sun, 19 Jun 2016 08:20:49 -0400 (EDT) Date: Sun, 19 Jun 2016 14:20:48 +0200 (CEST) From: Gerald Pfeifer To: Alexey Dokuchaev , "Vanilla I. Shu" , Zhihao Yuan cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r407452 - head/devel/pure-stldict In-Reply-To: <20160129074611.GA43436@FreeBSD.org> Message-ID: References: <201601290609.u0T69WQO078557@repo.freebsd.org> <20160129074611.GA43436@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 12:20:52 -0000 [ Full quote below ] I realize nobody copied them maintainer on this response; let me make up for this. (For now I have at least replaced USE_GCC=4.9 by USE_GCC=4.9+.) Gerald On Fri, 29 Jan 2016, Alexey Dokuchaev wrote: > On Fri, Jan 29, 2016 at 06:09:32AM +0000, Vanilla I. Shu wrote: >> New Revision: 407452 >> URL: https://svnweb.freebsd.org/changeset/ports/407452 >> >> Log: >> Fix broken on 9. > > There are several problems with this commit. :( > > Commit message does not tell us anything about the underlying problem, > we can only make guesses that it's likely related to the base GCC 4.2. > At this point, because of essentially missing commit log, we have to > look inside the Makefile: > > % CXXFLAGS+= -std=c++0x -DHAVE_STD_IS_PERMUTATION > > And the build error message with base GCC: > > cc1plus: error: unrecognized command line option "-std=c++0x" > > It suggests that the code conforms to C++0x and thus requires capable > compiler (at least). > > > +.include > > + > > +.if ${OSVERSION} <= 1000000 > > Strange OSVERSION; apparently it was supposed to reflect the moment when > Clang had become the default compiler? If so, it should've been 1000024. > If you want/need Clang together with libc++, then it is 1000054. > > Quick test with CXX=clang++ on 9.3, as well as compiler:c++0x/c++11-lang, > showed that compiler alone is not enough (see below). > > > +USE_GCC= 4.9 > > 4.9 seems strange; C++0x had appeared much earlier (`lang/pure' itself is > built with gcc48 on 9.3). Requesting specific version is not welcome, > and should be adequately explained (if some port really does require new > GCC, your first attempt should be USE_GCC=yes) in the commit log. > > More to it, requesting GCC here is bogus: what the port really wants is > compiler understanding C++11 and C++11-ready standard library. Consider > replacing bogus USE_GCC with USES+=compiler:c++11-lib. (Fixed the build > on 9.3 for me, with gcc48 as expected, and is no-op on 10.2 and -CURRENT.) > > ./danfe