From owner-freebsd-current@freebsd.org  Mon Jul 13 08:38:03 2015
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEDB899BCE0
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Mon, 13 Jul 2015 08:38:03 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B1D471BBE;
 Mon, 13 Jul 2015 08:38:03 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 8CCEF1FE022;
 Mon, 13 Jul 2015 10:38:02 +0200 (CEST)
Message-ID: <55A37933.3000802@selasky.org>
Date: Mon, 13 Jul 2015 10:39:15 +0200
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Kohji Okuno <okuno.kohji@jp.panasonic.com>, 
 freebsd-current@freebsd.org, Alexander Motin <mav@FreeBSD.org>
Subject: Re: Why shoud we cause panic in scsi_da.c?
References: <20150709.150520.1823457260978955949.okuno.kohji@jp.panasonic.com>
 <20150713.171110.531869520391748650.okuno.kohji@jp.panasonic.com>
In-Reply-To: <20150713.171110.531869520391748650.okuno.kohji@jp.panasonic.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2015 08:38:04 -0000

On 07/13/15 10:11, Kohji Okuno wrote:
> Hi,
>
> Could you comment on my quesion?
>
> Best regards,
>   Kohji Okuno
>
>> Hi,
>>
>> I found panic() in scsi_da.c. Please find the following.
>> I think we should return with error without panic().
>> What do you think about this?
>>
>> scsi_da.c:
>> 3018	                } else if (bp != NULL) {
>> 3019	                        if ((done_ccb->ccb_h.status & CAM_DEV_QFRZN) != 0)
>> 3020	                                panic("REQ_CMP with QFRZN");
>>

Hi,

It looks to me more like an KASSERT() is appropriate here.

Might be some people which can answer this are on vacation currently.

--HPS