Date: Tue, 18 May 2004 17:49:51 +0100 From: Doug Rabson <dfr@nlsystems.com> To: Harti Brandt <harti@freebsd.org> Cc: net@freebsd.org Subject: Re: new arp code snapshot for review... Message-ID: <1084898991.23208.14.camel@builder02.qubesoft.com> In-Reply-To: <Pine.GSO.4.60.0405181817030.16008@zeus> References: <20040425094940.A50968@xorpc.icir.org> <200405162013.33894.dfr@nlsystems.com> <Pine.GSO.4.60.0405181021470.8050@zeus> <20040518014828.B2380@xorpc.icir.org> <1084885227.23208.3.camel@builder02.qubesoft.com> <20040518090647.A39810@xorpc.icir.org> <Pine.GSO.4.60.0405181817030.16008@zeus>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2004-05-18 at 17:21, Harti Brandt wrote: > On Tue, 18 May 2004, Luigi Rizzo wrote: > > LR>On Tue, May 18, 2004 at 02:00:28PM +0100, Doug Rabson wrote: > LR>> On Tue, 2004-05-18 at 09:48, Luigi Rizzo wrote: > LR>> > I will try to remove as many assumptions as possible. > LR>> > thanks for the feedback. > LR>> > LR>> I think that in your prototype, the only assumption was in struct > LR>> llentry. I would suggest defining it as something like: > LR> > LR>to be really flexible, both l3_addr and ll_addr should be > LR>variable size (v4,v6,v8 over 802.x,firewire,appletalk,snail-mail), > LR>then things rapidly become confusing and inefficient. > LR>I would like to keep the ipv4 over ethernet case simple and quick, even > LR>if this means replicating the code for the generic case (and this > LR>is one of the reasons i have stalled a bit on this code -- i want > LR>to make up my mind on what is a reasonable approaxch). > > The most common use of that table is to have an l3_addr and search the > ll_addr, right? In that case making ll_addr variable shouldn't have a > measurable influence on speed. Variable l3_addr could be different though. Well it seems to me that IPv6 neighbour discovery is different enough from ARP that it makes sense to have IPv4-specialised ARP and IPv6-specialised ND. The only other variable is the size of the LL address and that doesn't add any significant complexity since its just moved around with bcopy.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1084898991.23208.14.camel>