Date: Tue, 14 Dec 2021 17:45:36 -0800 From: enh via freebsd-numerics <freebsd-numerics@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: enh via freebsd-numerics <freebsd-numerics@freebsd.org>, Steve Kargl <sgk@troutmask.apl.washington.edu>, Michal Meloun <mmel@freebsd.org> Subject: Re: s_sincosl.c: remove unused variable Message-ID: <CAJgzZoqRj2RRDoikXBcZzKoV7A=6PDN7LUT15oVXMU206YCO2w@mail.gmail.com> In-Reply-To: <E23114C9-4FCB-457C-99B3-5D1C2C57312B@FreeBSD.org> References: <CAJgzZoqrBgxto5k5eeJ1nuPu=BHLk1MfE74KN4rQh%2BghV8ehyQ@mail.gmail.com> <20211214200552.GA49922@troutmask.apl.washington.edu> <E23114C9-4FCB-457C-99B3-5D1C2C57312B@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000000ad01b05d325778d Content-Type: text/plain; charset="UTF-8" heh, no worries --- thanks to everyone here for maintaining the world's most-used (Android *and* iOS/macOS!) libm :-) On Tue, Dec 14, 2021 at 1:54 PM Dimitry Andric <dim@freebsd.org> wrote: > On 14 Dec 2021, at 21:05, Steve Kargl <sgk@troutmask.apl.washington.edu> > wrote: > > > > On Tue, Dec 14, 2021 at 11:06:53AM -0800, enh via freebsd-numerics wrote: > >> Newer versions of clang complain about this, and it seems genuinely > unneeded. > >> > >> It was in the original commit, and judging from that I think it's just > >> a copy & paste leftover from inlinine sinl() and cosl() --- the < > >> M_PI_4 case in sinl() needs the original sign. > > > > Yep. sgn is unneeded. Sorry about that. > > Thanks, committed in: > > https://cgit.freebsd.org/src/commit/?id=20d425842a4f80f9efc1de3f7a3b043435fe4b39 > > -Dimitry > > > --0000000000000ad01b05d325778d--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJgzZoqRj2RRDoikXBcZzKoV7A=6PDN7LUT15oVXMU206YCO2w>