From owner-svn-src-all@freebsd.org Fri Nov 6 21:08:13 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 12682A28F7B; Fri, 6 Nov 2015 21:08:13 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id E6D5012EC; Fri, 6 Nov 2015 21:08:12 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id DDF791E46; Fri, 6 Nov 2015 21:08:12 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 951FD12EE4; Fri, 6 Nov 2015 21:08:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id wcEaVN-ftL5P; Fri, 6 Nov 2015 21:08:05 +0000 (UTC) Subject: Re: svn commit: r290437 - head/usr.bin/netstat DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com B92EB12EDA To: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201511060843.tA68hCov032306@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <563D16BB.6060908@FreeBSD.org> Date: Fri, 6 Nov 2015 13:08:11 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <201511060843.tA68hCov032306@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oXOUQBpAl8nQAOnkbtaTJp6r0A6EM8F5c" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2015 21:08:13 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oXOUQBpAl8nQAOnkbtaTJp6r0A6EM8F5c Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/6/2015 12:43 AM, Garrett Cooper wrote: > Author: ngie > Date: Fri Nov 6 08:43:12 2015 > New Revision: 290437 > URL: https://svnweb.freebsd.org/changeset/base/290437 >=20 > Log: > Fix compiling netstat after r290367 by substituting sys/types.h for > sys/param.h, as sys/param.h defines the MAX(..) macro > =20 > Reported by: O. Hartmann > Pointyhat to: ume >=20 > Modified: > head/usr.bin/netstat/if.c >=20 > Modified: head/usr.bin/netstat/if.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/netstat/if.c Fri Nov 6 05:32:18 2015 (r290436) > +++ head/usr.bin/netstat/if.c Fri Nov 6 08:43:12 2015 (r290437) > @@ -37,7 +37,7 @@ static char sccsid[] =3D "@(#)if.c 8.3 (Be > #include > __FBSDID("$FreeBSD$"); > =20 > -#include > +#include > #include > #include > #include >=20 This is strange, it was building fine for days, and builds fine for me locally with reverting this change. While this may be proper, how is this a 'fix compiling' and a 'pointyhat'? --=20 Regards, Bryan Drewery --oXOUQBpAl8nQAOnkbtaTJp6r0A6EM8F5c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWPRa7AAoJEDXXcbtuRpfPCnUIAL4xrL2sp53jnNoPPu6qMUPS TFbjUMOBdCBIkSSY8t/5zY+J4lkqVJfKSgWM4MjH2YScI6RznVB8yXbp0bHf5e8d Jh3MCuQV2neygQD+Q8lZv8OCiqI4YGNOl72MiXw454wvRgbOREF3o+cPkkNN+SAN /JNZCFxrjJ40cCeQiVvU8NcAvQ+VNtB85PAPyi08+oIOuokkUPkoogzV6AsIZ3r5 l4OktDkIANJAr8MICEkfzG5gxT4lUlIEiOwtDlFhP2tpzgix/DuvdfcEBqSMxSDP 46BYOcXhnpmQ5g+k9Qqg74simYjE4F1pPDF+FkbNOhBxrEpzLE/u2+Zmen8FOmw= =L35k -----END PGP SIGNATURE----- --oXOUQBpAl8nQAOnkbtaTJp6r0A6EM8F5c--