From owner-cvs-all  Thu Dec 20  6:47: 1 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id BF6AC37B416; Thu, 20 Dec 2001 06:46:55 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id BAA17051;
	Fri, 21 Dec 2001 01:46:52 +1100
Date: Fri, 21 Dec 2001 01:46:50 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: Maxim Sobolev <sobomax@FreeBSD.org>
Cc: Peter Wemm <peter@FreeBSD.org>, <cvs-committers@FreeBSD.org>,
	<cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/alpha/alpha pmap.c src/sys/i386/i386 
 pmap.csrc/sys/ia64/ia64 pmap.c
In-Reply-To: <3C21F2F1.542EE5CC@FreeBSD.org>
Message-ID: <20011221014329.O1630-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, 20 Dec 2001, Maxim Sobolev wrote:

> > On Wed, 19 Dec 2001, Peter Wemm wrote:
> > >...
> > >   Replace a bunch of:
> > >         for (pv = TAILQ_FIRST(&m->md.pv_list);
> > >                  pv;
> > >                  pv = TAILQ_NEXT(pv, pv_list)) {
> > >   with:
> > >         TAILQ_FOREACH(pv, &m->md.pv_list, pv_list) {
> > >...
> > This is a regression IMO.  Please write C programs in something
> > resembling C.
>
> Why then we have all those *_FOREACH macros in sys/queue.h?

Opinions differ, and mine aren't quite strong enough to back out the
commit that added *_FOREACH.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message