From owner-cvs-all Thu Mar 7 15:31:15 2002 Delivered-To: cvs-all@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id 3010037B43D; Thu, 7 Mar 2002 15:30:39 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g27NUcS63628; Thu, 7 Mar 2002 23:30:38 GMT (envelope-from mark@grimreaper.grondar.za) Received: from grimreaper (localhost [127.0.0.1]) by grimreaper.grondar.org (8.12.2/8.12.2) with ESMTP id g27NS9RV049505; Thu, 7 Mar 2002 23:28:09 GMT (envelope-from mark@grimreaper.grondar.za) Message-Id: <200203072328.g27NS9RV049505@grimreaper.grondar.org> To: obrien@FreeBSD.ORG Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/dd args.c dd.c dd.h References: <20020307151333.A72218@hub.freebsd.org> In-Reply-To: <20020307151333.A72218@hub.freebsd.org> ; from "David O'Brien" "Thu, 07 Mar 2002 15:13:33 PST." Date: Thu, 07 Mar 2002 23:28:09 +0000 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > I have looked closer at many of your WARNS/lint(1) fixes. A lot of them > are very good. Your adding const in prototypes and to string vars, and > changing some `int' definitions to `u_int' (I don't care about the > spelling of unsigned int) are good. As is making more functions static. > These changes are hard to have problems with. Thanks! :-) > Is it possible to maybe commit WARNS/lint fixes in stages -- first the > total no brainers, and later those that might have more controversy? That is the intention. I guess I should drop the bar on what is a "no brainer". NP. Will do. M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message