From owner-svn-src-head@freebsd.org Fri Jun 12 17:54:15 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C8A40340FB6; Fri, 12 Jun 2020 17:54:15 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49k7dg0zvJz3Zfb; Fri, 12 Jun 2020 17:54:14 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 821C6260410; Fri, 12 Jun 2020 19:54:13 +0200 (CEST) Subject: Re: svn commit: r362110 - head/sys/compat/linuxkpi/common/include/linux From: Hans Petter Selasky To: Doug Moore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202006121748.05CHmCAU037945@repo.freebsd.org> <204b885c-bf12-d140-987b-d1c684ec2049@selasky.org> Message-ID: <05f111e5-5702-9d2d-5f4c-2b00ade844a8@selasky.org> Date: Fri, 12 Jun 2020 19:53:53 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <204b885c-bf12-d140-987b-d1c684ec2049@selasky.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 49k7dg0zvJz3Zfb X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-2.33 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_LONG(-0.97)[-0.966]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.960]; NEURAL_HAM_SHORT(-0.10)[-0.101]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2020 17:54:15 -0000 On 2020-06-12 19:51, Hans Petter Selasky wrote: > On 2020-06-12 19:48, Doug Moore wrote: >> Author: dougm >> Date: Fri Jun 12 17:48:12 2020 >> New Revision: 362110 >> URL: https://svnweb.freebsd.org/changeset/base/362110 >> >> Log: >>    Revert r362108, as it breaks compilation. >> >> Modified: >>    head/sys/compat/linuxkpi/common/include/linux/rbtree.h >> >> Modified: head/sys/compat/linuxkpi/common/include/linux/rbtree.h >> ============================================================================== >> >> --- head/sys/compat/linuxkpi/common/include/linux/rbtree.h    Fri Jun >> 12 17:31:38 2020    (r362109) >> +++ head/sys/compat/linuxkpi/common/include/linux/rbtree.h    Fri Jun >> 12 17:48:12 2020    (r362110) >> @@ -37,8 +37,8 @@ >>   struct rb_node { >>       RB_ENTRY(rb_node)    __entry; >>   }; >> -#define    rb_left        RB_PTR(__entry.rbe_left) >> -#define    rb_right    RB_PTR(__entry.rbe_right) >> +#define    rb_left        __entry.rbe_left >> +#define    rb_right    __entry.rbe_right >>   /* >>    * We provide a false structure that has the same bit pattern as tree.h >> > > Are you planning to fix those compilation errors? > Or is the current code fine? --HPS