From owner-svn-src-all@FreeBSD.ORG  Thu Jul 22 20:34:45 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0A8FE1065673;
	Thu, 22 Jul 2010 20:34:45 +0000 (UTC)
	(envelope-from dimitry@andric.com)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
	[IPv6:2001:7b8:2ff:146::2])
	by mx1.freebsd.org (Postfix) with ESMTP id BABFB8FC0A;
	Thu, 22 Jul 2010 20:34:44 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:75f8:f22a:c609:cdab] (unknown
	[IPv6:2001:7b8:3a7:0:75f8:f22a:c609:cdab])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id D58745C59;
	Thu, 22 Jul 2010 22:34:42 +0200 (CEST)
Message-ID: <4C48AB65.1030207@andric.com>
Date: Thu, 22 Jul 2010 22:34:45 +0200
From: Dimitry Andric <dimitry@andric.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US;
	rv:1.9.2.8pre) Gecko/20100718 Lanikai/3.1.2pre
MIME-Version: 1.0
To: Jung-uk Kim <jkim@FreeBSD.org>
References: <201007221847.o6MIlfxH030805@svn.freebsd.org>
	<201007221614.11334.jkim@FreeBSD.org>
In-Reply-To: <201007221614.11334.jkim@FreeBSD.org>
Content-Type: multipart/mixed; boundary="------------090102040807080106080007"
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, Rui Paulo <rpaulo@FreeBSD.org>
Subject: Re: svn commit: r210384 - head/sys/conf
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jul 2010 20:34:45 -0000

This is a multi-part message in MIME format.
--------------090102040807080106080007
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On 2010-07-22 22:13, Jung-uk Kim wrote:
>>  CFLAGS=	${COPTFLAGS} ${C_DIALECT} ${DEBUG} ${CWARNFLAGS}
>>  CFLAGS+= ${INCLUDES} -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS
>> -include opt_global.h -.if ${CC} != "icc"
>> +.if ${CC} != "icc" && ${CC} != "clang"
>>  CFLAGS+= -fno-common -finline-limit=${INLINE_LIMIT}
>>  .if ${MACHINE_CPUARCH} != "mips"
>>  CFLAGS+= --param inline-unit-growth=100
> 
> Isn't it little premature to remove -Werror from clang?

Yes, probably.  Please consider the attached patch, which only rubs out
the compilation options that clang does not support.

--------------090102040807080106080007
Content-Type: text/plain;
 name="clang-bootstrap-r210393-1-werror.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="clang-bootstrap-r210393-1-werror.diff"

diff --git a/sys/conf/kern.pre.mk b/sys/conf/kern.pre.mk
index 5c22abd..7642fca 100644
--- a/sys/conf/kern.pre.mk
+++ b/sys/conf/kern.pre.mk
@@ -92,7 +92,8 @@ INCLUDES+= -I$S/dev/cxgb
 
 CFLAGS=	${COPTFLAGS} ${C_DIALECT} ${DEBUG} ${CWARNFLAGS}
 CFLAGS+= ${INCLUDES} -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h
-.if ${CC} != "icc" && ${CC} != "clang"
+.if ${CC} != "icc"
+.if ${CC} != "clang"
 CFLAGS+= -fno-common -finline-limit=${INLINE_LIMIT}
 .if ${MACHINE_CPUARCH} != "mips"
 CFLAGS+= --param inline-unit-growth=100
@@ -102,6 +103,7 @@ CFLAGS+= --param large-function-growth=1000
 CFLAGS+= --param inline-unit-growth=1000
 CFLAGS+= --param large-function-growth=100000
 .endif
+.endif
 WERROR?= -Werror
 .endif
 

--------------090102040807080106080007--