From owner-svn-src-all@FreeBSD.ORG Fri Apr 24 15:03:36 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D8759B48; Fri, 24 Apr 2015 15:03:36 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B301E16CA; Fri, 24 Apr 2015 15:03:36 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id A5D63B95E; Fri, 24 Apr 2015 11:03:35 -0400 (EDT) From: John Baldwin To: Sergey Kandaurov Cc: Edward Tomasz Napierala , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r281922 - head/usr.bin/nfsstat Date: Fri, 24 Apr 2015 10:33:56 -0400 Message-ID: <1589639.roM6gzoYx3@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; ) In-Reply-To: References: <201504240758.t3O7w0o1022549@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 24 Apr 2015 11:03:35 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2015 15:03:37 -0000 On Friday, April 24, 2015 02:31:31 PM Sergey Kandaurov wrote: > On 24 April 2015 at 10:58, Edward Tomasz Napierala wrote: > > Author: trasz > > Date: Fri Apr 24 07:57:59 2015 > > New Revision: 281922 > > URL: https://svnweb.freebsd.org/changeset/base/281922 > > > > Log: > > Make nfsstat(1) build with WARNS=6. > > > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > head/usr.bin/nfsstat/Makefile > > head/usr.bin/nfsstat/nfsstat.c > > > > Modified: head/usr.bin/nfsstat/Makefile > > ============================================================================== > > --- head/usr.bin/nfsstat/Makefile Fri Apr 24 07:52:21 2015 (r281921) > > +++ head/usr.bin/nfsstat/Makefile Fri Apr 24 07:57:59 2015 (r281922) > > @@ -6,6 +6,4 @@ CFLAGS+=-DNFS > > > > LIBADD= kvm > > > > -WARNS?= 3 > > - > > .include > > > > Modified: head/usr.bin/nfsstat/nfsstat.c > > ============================================================================== > > --- head/usr.bin/nfsstat/nfsstat.c Fri Apr 24 07:52:21 2015 (r281921) > > +++ head/usr.bin/nfsstat/nfsstat.c Fri Apr 24 07:57:59 2015 (r281922) > > @@ -70,15 +70,6 @@ static const char rcsid[] = > > #include > > #include > > > > -struct nlist nl[] = { > > -#define N_NFSSTAT 0 > > - { .n_name = "nfsstats" }, > > -#define N_NFSRVSTAT 1 > > - { .n_name = "nfsrvstats" }, > > - { .n_name = NULL }, > > -}; > > -kvm_t *kd; > > - > > static int widemode = 0; > > static int zflag = 0; > > static int printtitle = 1; > > > > Now that nfsstat no longer uses kvm to extract statistics, it could be > further trimmed. > - no longer link with kvm > - un-document -M/-N options but still kept (?) for backward compatibility > - cleanup from the previous sysctl/kvm usage. If these are just global structures in the kernel it would be nice to keep -N/-M support for use in crash dump reporting. This just broke crashinfo (again), so please either restore KVM support for crash reporting, or remove nfsstat from crashinfo. -- John Baldwin