From owner-freebsd-net@FreeBSD.ORG Mon Apr 23 08:03:40 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 23BE816A400 for ; Mon, 23 Apr 2007 08:03:40 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 8AD4213C46E for ; Mon, 23 Apr 2007 08:03:39 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 75053 invoked from network); 23 Apr 2007 07:26:34 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 23 Apr 2007 07:26:33 -0000 Message-ID: <462C6859.7080603@freebsd.org> Date: Mon, 23 Apr 2007 10:03:37 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Bruce M Simpson References: <4628DA3A.3050309@incunabulum.net> <20070420104318.A67833@xorpc.icir.org> <462C5405.8040401@incunabulum.net> In-Reply-To: <462C5405.8040401@incunabulum.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD-Net mailing list Subject: Re: MFC of ether_input() changes X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2007 08:03:40 -0000 Bruce M Simpson wrote: > Actually, I thought the change which moved the VLAN tag out of the mbuf > tag pool and into the mbuf packet header had also been MFCed. It has not. It would be an API+ABI change to MFC it. That's why I haven't done it. > As CURRENT is the branch normally used for feature development it is > probably best I don't MFC this unless the VLAN tag change is MFCed also. > > Therefore there is not a lot of point in merging this change apart from > to benefit from the code cleanup which M_PROMISC offers, so I'll back > off for now. -- Andre