From nobody Thu Jan 16 18:08:29 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YYrTB59xHz5kkqC; Thu, 16 Jan 2025 18:08:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YYrT974C1z3Rq6; Thu, 16 Jan 2025 18:08:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737050910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rAf2kUJ+8J4w9KdCPr31RtF3mEMHtBDPqpJoltY9Kso=; b=gzaSMiNMebE7BUuYaOhmSLDooikWtvuRiuz3vPBHswclVIDYIZOyuG1d+l+J9dbDrrH6t3 7QCl0ZwzBDWOFl8mlXqx8G8ZaoZVcgkIZsOquip2IsSLwFPHjDF90/doAK95N3bA9UTMU4 SOc0zxLoaxdiFqp0kxmtiB2lQ0VE6x+SW3JpTkc5wg0ZrAgUu6OOkyL7Qyr9NJzLb4K2q6 HL2GEoDcJ88Y2olzVGS2KUeT8fAzVBpAUx8NxrTygNrQ2bx1zkFzty+BrXY1Pa6T/4FX+H n6nscoe2D+TEC5x7zDIwSwsfDiVD3mSSqDjNPrNO/ybv465bK0ytWNVQ1eds0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737050910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rAf2kUJ+8J4w9KdCPr31RtF3mEMHtBDPqpJoltY9Kso=; b=m8fJ1mDcGSRKJQG8y+o+uDKbtMFKAgrkFZjSw3QBpJibj5GORlBj+zH7Sho4EB4+jphJiV XGn415KCmGTV4gyBoY4xZew6rQhryWCMNSW/LwBJ37wVXiQQ7xCj3YIIumbzZZtTp7aCaJ MuHBRtUCsnSK56ZNwcIbX0xfalanOgittQI+Svhluhza/UhXEaAGyB3QJUu6ItdJG3RnLH mTdwaZoMUeNsevxWd1FVU4Gcq+i+qx6GaeB+xdG75tqOSGDYmGfmELWKmV0qL4z+5KbrFV OMiOgnF00kUtlyqw1ysEF6B3L4Pvi07duhKxRkSarJMJpFLbvTf1tuHm1GlJ0w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737050910; a=rsa-sha256; cv=none; b=YmLI4vzozElJ7gRLsOzX5YSrUdxdCO60haT++2xXta47K4PJKnW69syRFZuZfsKZu8S1FA TC/jrbzufYU5XdmTwqfjbnpoDXrpU5Srh9eU7Tip/mpGeRaXVOtZIbbSL4syfxKW/CKk7J k7Xaj3abddx2Q9vp3uGG3xeRG0cl4OVD6wsyb/h2ifOcqbEFQDmIT7MLMfPMc4akdr6+qD Nrek8GiQr2M4fYWfEtDCZYSG5PtYCLueWLQbHFJcXjIjA0EivgK89z+GiU++Z/FtbnNHCP JKfjXma2LMF1kbzX/7JzxLjU5b1SU+1CgmInmePVfABMjtCC5h07h3a7Ocn+iA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YYrT96TcGzk15; Thu, 16 Jan 2025 18:08:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50GI8TAo092482; Thu, 16 Jan 2025 18:08:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50GI8TFn092479; Thu, 16 Jan 2025 18:08:29 GMT (envelope-from git) Date: Thu, 16 Jan 2025 18:08:29 GMT Message-Id: <202501161808.50GI8TFn092479@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: d1830c75865c - stable/14 - cred: proc_set_cred(): Remove obsolete comments List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d1830c75865c880c895c289e049c6649b20b9a4b Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=d1830c75865c880c895c289e049c6649b20b9a4b commit d1830c75865c880c895c289e049c6649b20b9a4b Author: Olivier Certner AuthorDate: 2024-08-01 10:19:52 +0000 Commit: Olivier Certner CommitDate: 2025-01-16 18:06:59 +0000 cred: proc_set_cred(): Remove obsolete comments These have been obsoleted since they were first written (in commit "cred: add proc_set_cred helper", daf63fd2f9a8d040, r280130) by some subsequent commits ("proc: refactor clearing credentials into proc_unset_cred", 5a90435ccfed8e1e, r361448; "cred: distribute reference count per thread", 1724c563e62fa800, r361993). No functional change. Approved by: markj (mentor) MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46922 (cherry picked from commit 07c9edac7bcd75095724ff3c91d0aeec792a4f26) --- sys/kern/kern_prot.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c index 3510dc16f731..bf026593a3ee 100644 --- a/sys/kern/kern_prot.c +++ b/sys/kern/kern_prot.c @@ -2281,11 +2281,6 @@ cru2xt(struct thread *td, struct xucred *xcr) * Change process credentials. * Callers are responsible for providing the reference for passed credentials * and for freeing old ones. - * - * Process has to be locked except when it does not have credentials (as it - * should not be visible just yet) or when newcred is NULL (as this can be - * only used when the process is about to be freed, at which point it should - * not be visible anymore). */ void proc_set_cred(struct proc *p, struct ucred *newcred)