Date: Fri, 28 Jan 2011 11:10:37 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Hans Petter Selasky <hselasky@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r218010 - head/usr.sbin/usbdump Message-ID: <20110128101037.GF1729@garage.freebsd.pl> In-Reply-To: <201101280800.p0S80vtb064968@svn.freebsd.org> References: <201101280800.p0S80vtb064968@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--+ts6NCQ4mrNQIV8p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 28, 2011 at 08:00:57AM +0000, Hans Petter Selasky wrote: > Author: hselasky > Date: Fri Jan 28 08:00:57 2011 > New Revision: 218010 > URL: http://svn.freebsd.org/changeset/base/218010 >=20 > Log: > - Remove double semicolon. > - Remove reference to sprintf. Use printf directly. This part of > the code should be optimised further to avoid many small printouts. > Setting a sensible line buffer length could help aswell when printing > out megabytes of data per second. > =20 > Approved by: thompsa (mentor) [...] > +#define EMIT(fmt, ...) do { \ > + printf(fmt,## __VA_ARGS__); \ > } while (0) Or: #define EMIT(...) printf(__VA_ARGS__) --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --+ts6NCQ4mrNQIV8p Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk1ClhwACgkQForvXbEpPzTw8wCfaog6vuxqr1uPNjqmGKbwa3xE 538AnAz7MljD46oRlQKR7/i9rX7+PXXl =S0MV -----END PGP SIGNATURE----- --+ts6NCQ4mrNQIV8p--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110128101037.GF1729>