From owner-cvs-all Sat Mar 24 0: 5:12 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id B9B3037B719; Sat, 24 Mar 2001 00:05:02 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id TAA23115; Sat, 24 Mar 2001 19:05:00 +1100 Date: Sat, 24 Mar 2001 19:04:24 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: John Baldwin Cc: Hajimu UMEMOTO , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/include/arpa inet.h src/sys/netinet in.h src In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 23 Mar 2001, John Baldwin wrote: > On 23-Mar-01 Hajimu UMEMOTO wrote: > > ... > > Log: > > IPv4 address is not unsigned int. This change introduces in_addr_t. > It seems i386 is evil and doesn't use in_addr_t or in_port_t in its > machine/endian.h. This probably breaks ia64 as well. Will you move in_port_t > into sys/types.h as well and then convert the i386 endian.h to use the right > types? wollman once objected to using it there. I don't remember why, but it may have been because these types are misspellings of uint32_t, etc. ipv4 addresses have precisely 32 bits, so using an opaque type for them can be considered bogus. Also, in_addr_t is a bogus name. Only ipv4 internet address fit in it. I use uint32_t (misspelled as u_int) in my i386 endian.h to "fix" ntohl(), etc., for i386's with 64-bit longs. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message