From owner-cvs-src-old@FreeBSD.ORG Tue Mar 9 09:49:46 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D588C1065675 for ; Tue, 9 Mar 2010 09:49:46 +0000 (UTC) (envelope-from qingli@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C2F908FC20 for ; Tue, 9 Mar 2010 09:49:46 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o299nkt5036565 for ; Tue, 9 Mar 2010 09:49:46 GMT (envelope-from qingli@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o299nkN2036564 for cvs-src-old@freebsd.org; Tue, 9 Mar 2010 09:49:46 GMT (envelope-from qingli@repoman.freebsd.org) Message-Id: <201003090949.o299nkN2036564@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to qingli@repoman.freebsd.org using -f From: Qing Li Date: Tue, 9 Mar 2010 01:11:45 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net flowtable.c radix.c radix_mpath.c route.c route.h src/sys/netinet in.c ip_output.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2010 09:49:46 -0000 qingli 2010-03-09 01:11:45 UTC FreeBSD src repository Modified files: sys/net flowtable.c radix.c radix_mpath.c route.c route.h sys/netinet in.c ip_output.c Log: SVN rev 204902 on 2010-03-09 01:11:45Z by qingli One of the advantages of enabling ECMP (a.k.a RADIX_MPATH) is to allow for connection load balancing across interfaces. Currently the address alias handling method is colliding with the ECMP code. For example, when two interfaces are configured on the same prefix, only one prefix route is installed. So connection load balancing among the available interfaces is not possible. The other advantage of ECMP is for failover. The issue with the current code, is that the interface link-state is not reflected in the route entry. For example, if there are two interfaces on the same prefix, the cable on one interface is unplugged, new and existing connections should switch over to the other interface. This is not done today and packets go into a black hole. Also, there is a small bug in the kernel where deleting ECMP routes in the userland will always return an error even though the command is successfully executed. MFC after: 5 days Revision Changes Path 1.25 +2 -1 src/sys/net/flowtable.c 1.49 +2 -0 src/sys/net/radix.c 1.11 +2 -1 src/sys/net/radix_mpath.c 1.173 +30 -8 src/sys/net/route.c 1.88 +2 -0 src/sys/net/route.h 1.158 +8 -0 src/sys/netinet/in.c 1.323 +5 -1 src/sys/netinet/ip_output.c