From owner-freebsd-ports  Sun Mar 25 16:50: 8 2001
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 4CAF537B71E
	for <freebsd-ports@hub.freebsd.org>; Sun, 25 Mar 2001 16:50:01 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f2Q0o1176359;
	Sun, 25 Mar 2001 16:50:01 -0800 (PST)
	(envelope-from gnats)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id CBC8B37B71A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Mar 2001 16:47:33 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f2Q0lXc76237;
	Sun, 25 Mar 2001 16:47:33 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200103260047.f2Q0lXc76237@freefall.freebsd.org>
Date: Sun, 25 Mar 2001 16:47:33 -0800 (PST)
From: bsdx@looksharp.net
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: ports/26087: fix upgrade of icewm port so it compiles
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         26087
>Category:       ports
>Synopsis:       fix upgrade of icewm port so it compiles
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 25 16:50:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Adam McDougall
>Release:        4.2-STABLE
>Organization:
>Environment:
FreeBSD sapphire.looksharp.net 4.2-STABLE FreeBSD 4.2-STABLE #0: Sat Feb  3 12:40:32 EST 2001     root@holdenrh157-reg-171:/itg3/obj/itg2/src/sys/SAPPHIRE-STABLE-SMP  i386

>Description:
icewm 1.0.7 is broken, doesnt compile, bento reflects this
>How-To-Repeat:
cvsup ports
cd /usr/ports/x11-wm/icewm && make
>Fix:
Looks like it wasn't including /usr/local/include so it could find a header for gettext.  This patch fixes it, but I dont know if it is correct.  A working port for a popular window manager is more important than a broken one with a release coming up.
Thanks to the folks who helped me out with Makefile and ports syntax some. 
http://www.looksharp.net/~user1/icewm1.0.7-7-patch.diff
Pasted below for eyeballing, tabs probably blown.
diff -urN icewm/Makefile icewm.patched/Makefile
--- icewm/Makefile      Sat Mar 17 06:19:07 2001
+++ icewm.patched/Makefile      Sun Mar 25 18:09:38 2001
@@ -30,6 +30,8 @@
                --with-kdedatadir=${LOCALBASE}/share \
                --with-docdir=${PREFIX}/share/doc
 
+MAKE_ENV=      CPPFLAGS="-I${LOCALBASE}/include"
+
 .include <bsd.port.pre.mk>
 
 .if defined(HAVE_GNOME)
diff -urN icewm/files/patch-src_Makefile icewm.patched/files/patch-src_Makefile
--- icewm/files/patch-src_Makefile      Sat Mar 17 06:19:08 2001
+++ icewm.patched/files/patch-src_Makefile      Sun Mar 25 19:26:52 2001
@@ -1,15 +1,18 @@
---- src/Makefile.orig  Sat Mar 17 05:17:37 2001
-+++ src/Makefile       Sat Mar 17 19:09:15 2001
-@@ -14,9 +14,9 @@
+--- src/Makefile.unpatched     Sun Mar 25 19:16:54 2001
++++ src/Makefile       Sun Mar 25 19:20:37 2001
+@@ -14,10 +14,11 @@
        -DPACKAGE='"icewm"' \
        -DVERSION='"$(VERSION)"' \
        -DEXEEXT='"$(EXEEXT)"' \
 -      -DICEWMEXE='"icewm"EXEEXT' \
 -      -DICEHELPEXE='"icehelp"EXEEXT' \
 -      -DICEHELPIDX='"$(DOCDIR)/icewm-$(VERSION)/doc/icewm.html"' \
+-        $(SYS_CFLAGS) $(SYS_INCDIRS)
 +      -DICEWMEXE='"icewm$(EXEEXT)"' \
 +      -DICEHELPEXE='"icehelp$(EXEEXT)"' \
 +      -DICEHELPIDX='"$(DOCDIR)/icewm/icewm.html"' \
-         $(SYS_CFLAGS) $(SYS_INCDIRS)
++        $(SYS_CFLAGS) $(SYS_INCDIRS) \
++      $(CPPFLAGS)
  LFLAGS = $(SYS_LIBDIRS) 
  LIBS = $(SYS_LIBS)
+ 

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message