From owner-freebsd-multimedia@FreeBSD.ORG Tue Nov 8 15:17:58 2005 Return-Path: X-Original-To: multimedia@freebsd.org Delivered-To: freebsd-multimedia@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27A3116A41F for ; Tue, 8 Nov 2005 15:17:58 +0000 (GMT) (envelope-from hopet@ics.muni.cz) Received: from tirith.ics.muni.cz (tirith.ics.muni.cz [147.251.4.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 974F243D46 for ; Tue, 8 Nov 2005 15:17:51 +0000 (GMT) (envelope-from hopet@ics.muni.cz) Received: from KLOBOUCEK (kloboucek.ics.muni.cz [147.251.3.38]) (user=hopet@META mech=LOGIN bits=0) by tirith.ics.muni.cz (8.13.2/8.13.2) with ESMTP id jA8FHmLU018066 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Tue, 8 Nov 2005 16:17:49 +0100 From: "Petr Holub" To: "John-Mark Gurney" Date: Tue, 8 Nov 2005 16:17:50 +0100 Message-ID: <009e01c5e477$955fc590$5317fb93@KLOBOUCEK> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook 8.5, Build 4.71.2377.0 In-Reply-To: <20051108083004.GM775@funkthat.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1506 Importance: Normal X-Muni-Spam-TestIP: 147.251.3.38 X-Muni-Envelope-From: hopet@ics.muni.cz X-Muni-Virus-Test: Clean Cc: multimedia@freebsd.org Subject: RE: [PATCH] MPEG2-TS patch for fwcontrol X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2005 15:17:58 -0000 > Looks good, though you have a number of lines, both in the man page > and in source that are over 80 columns... also, a quick pass after > reading style(9) would be good... (variables aren't sorted properly > in mpegtsrecv, else not on same line as brace, spaces around if missing).. > you might want to update the year of the copyright :) OK, I've tried to stylify the patches and the new version are again available here: for 5.x: http://sitola.fi.muni.cz/~hopet/HDV/fwcontrol.patch for 6.x: http://sitola.fi.muni.cz/~hopet/HDV/fwcontrol-6.0.patch > Otherwise looks good... Have you looked at being able to send MPEG2-TS? > I wonder if it'd work w/ a DVHS deck, or a firewire capable HDTV tuner > like the Samsung SIR-T165... Sending - not yet. It's a little bit more complicated process because of the rules for data packetization on FireWire. As for the DVHS decks, I don't have any so I can't try that. The functionality of the patches has been verified using both SONY cameras mentioned in my previous mail. Petr ================================================================ Petr Holub CESNET z.s.p.o. Supercomputing Center Brno Zikova 4 Institute of Compt. Science 162 00 Praha 6, CZ Masaryk University Czech Republic Botanicka 68a, 60200 Brno, CZ e-mail: Petr.Holub@cesnet.cz phone: +420-549493944 fax: +420-541212747 e-mail: hopet@ics.muni.cz