From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Feb 1 21:52:17 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3133F183 for ; Sun, 1 Feb 2015 21:52:17 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 129C5A9F for ; Sun, 1 Feb 2015 21:52:17 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t11LqGZb085811 for ; Sun, 1 Feb 2015 21:52:16 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197255] [PATCH] net/samba41: testparm_command in rc script doesn't use samba_server_config from rc.conf Date: Sun, 01 Feb 2015 21:52:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: guyyur@gmail.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: timur@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2015 21:52:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197255 Bug ID: 197255 Summary: [PATCH] net/samba41: testparm_command in rc script doesn't use samba_server_config from rc.conf Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: timur@FreeBSD.org Reporter: guyyur@gmail.com Flags: maintainer-feedback?(timur@FreeBSD.org) Assignee: timur@FreeBSD.org Created attachment 152457 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=152457&action=edit patch for samba_server.in Description: A samba_server_config statement in rc.conf is ignored and the default is used by samba_server rc script because it specifies testparm_command after samba_server_config is set to $samba_server_config_default and before load_rc_config sets it from rc.conf. Attached patch to: 1. move load_rc_config for "samba_server" to before checking samba_server_role. 2. move setting samba_server_config, testparm_command to after doing load_rc_config for "samba_server". 3. fix winbindd being started when winbindd_enable is unset and samba_server_idmap is not specified in config file. (comment at start of script "You need to enable winbindd separately") # grep samba_server /etc/rc.conf samba_server_enable="YES" samba_server_config="/usr/local/etc/smb.conf" # sh -x /usr/local/etc/rc.d/samba_server start + . /etc/rc.subr + : 28915 + export RC_PID + [ -z '' ] + _rc_subr_loaded=YES ... + name=samba_server + rcvar=samba_server_enable + samba_server_config_default=/usr/local/etc/smb4.conf + samba_server_config=/usr/local/etc/smb4.conf + samba_server_configfile_arg=--configfile=/usr/local/etc/smb4.conf + testparm_command='/usr/local/bin/testparm --suppress-prompt --verbose /usr/local/etc/smb4.conf' ... + load_rc_config samba_server ... + samba_server_enable=YES + samba_server_config=/usr/local/etc/smb.conf ... + [ winbindd = winbindd ] + /usr/local/bin/testparm --suppress-prompt --verbose /usr/local/etc/smb4.conf '--parameter-name=idmap uid' + samba_server_idmap='' + [ -n '' ] + eval 'winbindd_enable=${winbindd_enable-YES}' + winbindd_enable=YES + eval 'winbindd_enable=${winbindd_enable:-NO}' + winbindd_enable=YES --- Comment #1 from Bugzilla Automation --- Auto-assigned to maintainer timur@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.