From nobody Thu Feb 5 03:12:26 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f62Mr2xfKz6R4yH; Thu, 05 Feb 2026 03:12:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4f62Mq6NfSz3sDl; Thu, 05 Feb 2026 03:12:39 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 6153CQLA095178; Thu, 5 Feb 2026 05:12:29 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 6153CQLA095178 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 6153CQsm095177; Thu, 5 Feb 2026 05:12:26 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 Feb 2026 05:12:26 +0200 From: Konstantin Belousov To: "Enji Cooper (yaneurabeya)" Cc: Abdelkader Boudih , Adrian Chadd , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware Message-ID: References: <698154c0.35e9d.2d7b8775@gitrepo.freebsd.org> <0A69735E-8BF6-41B1-AB7A-9B761A0FF158@gmail.com> <63ee9a06-97bd-4f7f-8bb8-ed39382d94a4@app.fastmail.com> <25B2F11A-19F2-452E-971E-3C2C953540C5@gmail.com> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <25B2F11A-19F2-452E-971E-3C2C953540C5@gmail.com> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4f62Mq6NfSz3sDl X-Spamd-Bar: ---- On Wed, Feb 04, 2026 at 07:02:00PM -0800, Enji Cooper (yaneurabeya) wrote: > > > On Feb 4, 2026, at 1:17 PM, Konstantin Belousov wrote: > > > > On Tue, Feb 03, 2026 at 10:25:27PM -0800, Enji Cooper (yaneurabeya) wrote: > >> > >>> On Feb 3, 2026, at 2:38 AM, Konstantin Belousov wrote: > >>> > >>> On Tue, Feb 03, 2026 at 11:08:40AM +0100, Abdelkader Boudih wrote: > >>>> I agree that this should not be permanent verbosity. > >>>> > >>>> The aim was not to add long-term noise, but to make the behavior observable/greppable to reviewers while this logic is still being validated across a wide range of Apple models. > >>>> > >>>> I'm going to get few Apple devices to try on. Once we confirm that every model behave the same, we could totally remove verbosity and treating it as assumed-working code. > >> > >> One sidenote: this is hidden behind bootverbose: it’s not always being displayed. > >> > >> I think it’s fine making the message more terse. It might clarify behavior on Apple platforms since the added behavior contradicts other OSI-related behavior and can result in a POLA violation. > > > > Can you fix it, please, instead thinking that it might be fine? > > Done: https://cgit.freebsd.org/src/commit/?id=9c666de5b339d3c8f9bf3963691e4310e7d159cb > -Enji Thank you.