From nobody Fri Jul 4 13:28:50 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bYZGV6cS5z615CJ; Fri, 04 Jul 2025 13:28:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bYZGV5B6Nz3M4W; Fri, 04 Jul 2025 13:28:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751635730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VLUlqaXlpT1I/WJw1byot1bmBovCTj43g8ZRCMMmF3E=; b=RYAGarNZn/WYFmYZHFZBBbxoP/xonVTOqElpHXkss9nLXnad/mfoXziWaSxkupK9OnbR1D +b1vrw+icDF4Raqg9rqB4joobWkyy0KpPherZE+aAaTt2E2OKCcNfQJenNdChyoEgiCN/L YOhD47xY4uTEzHUxsYhXnWv12t4KiVRjKUXXGHt4dfcRZ1JE6rHhaSXTHa3MQ/T+l+jqJu BRVJr34yQKHfArm7usxwV71kq9+/4rWhx4Apm0lXq90wngDSiiIuTLfI/ZawTRpoGYrVcf Qyl2U8LYb1igka1dA/l0GeoMDuVrhSmiHntGdzJXQ8ppSE37LlMKVhuV1E0R6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751635730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VLUlqaXlpT1I/WJw1byot1bmBovCTj43g8ZRCMMmF3E=; b=K+1CNuvV72l7vPWET0gUHwOq2mWBxwM3I9wnWkS0MyoAIvlHoIBvehjY623X2eL6E0lH6Z I75HvnWwm5NLOXV3Mi6oxLZolFma+qqt4FxPzFqxUxZdz4s34gagKMr0mv3/gVindO6mjd e4264DGnT0WzBWa96QqlwYjvuQQkwGTCuLadf5tg2F7P4GhAGAGNNFs4I0yDTOwdAQ4AVE y2MJAPQHqjF15zV8Zrg8zVi49eWkZKm5fdBNATTOt3vzFCnUW60BJDI+kk10gBEeNbJUPD 0NKSQEIJs3bSD01Ig8cEu/lYNvYEaYdkf52R+iZ0lI7o8TnG8SjwErv1kXJAOA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751635730; a=rsa-sha256; cv=none; b=j4POl1wOiBs0au7bPvNjeprX88olQex7yCFwibSMwg0f7/yEJ6INudBYN22Q7WlCZCDcII dL4HHJ/Bt9cjw+FnJ909LgYf7HKT/KZx0fwVOmhVCDZ5ChvlsfmYSjl2i/OIJeJQVwX5xN 5H0YjhpYMa2eISD98PpKWCr5dsknvMqED85aLrjFrHKUDd7z5owXjbWn3TJgptAcQSIaBu VKr4v7ixulZEYbiaPhi3OMbJlye0pA25H2i7IYS64X2VM3oMxlYxwlVfKKkv5Yv8DoAe0l A3uu+y1jxGEdlLpRfGz7yT6/DIXk7IoPtpUyMOe8A2fwq5vfiifnOz2Ym0lPhA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bYZGV49hZzsGZ; Fri, 04 Jul 2025 13:28:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 564DSoKo005986; Fri, 4 Jul 2025 13:28:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 564DSoZi005983; Fri, 4 Jul 2025 13:28:50 GMT (envelope-from git) Date: Fri, 4 Jul 2025 13:28:50 GMT Message-Id: <202507041328.564DSoZi005983@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Gleb Popov Subject: git: ec70e1177b20 - stable/14 - p9fs: remove duplicated code List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: arrowd X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: ec70e1177b2004a5990222dbe3bd6130d9566822 Auto-Submitted: auto-generated The branch stable/14 has been updated by arrowd: URL: https://cgit.FreeBSD.org/src/commit/?id=ec70e1177b2004a5990222dbe3bd6130d9566822 commit ec70e1177b2004a5990222dbe3bd6130d9566822 Author: Danilo Egea Gondolfo AuthorDate: 2024-07-09 19:07:18 +0000 Commit: Gleb Popov CommitDate: 2025-07-04 13:28:06 +0000 p9fs: remove duplicated code This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1323 (cherry picked from commit a6ca6dfd60b66eec563bd473d96b31f0be1de80a) --- sys/fs/p9fs/p9fs_vnops.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sys/fs/p9fs/p9fs_vnops.c b/sys/fs/p9fs/p9fs_vnops.c index 5556e60f4bae..6ac0a7c008cc 100644 --- a/sys/fs/p9fs/p9fs_vnops.c +++ b/sys/fs/p9fs/p9fs_vnops.c @@ -125,16 +125,6 @@ p9fs_cleanup(struct p9fs_node *np) /* Destroy the vm object and flush associated pages. */ vnode_destroy_vobject(vp); - /* Remove the vnode from hash list if vnode is not already deleted */ - if ((np->flags & P9FS_NODE_DELETED) == 0) - vfs_hash_remove(vp); - - /* Invalidate all entries to a particular vnode. */ - cache_purge(vp); - - /* Destroy the vm object and flush associated pages. */ - vnode_destroy_vobject(vp); - /* Remove all the FID */ p9fs_fid_remove_all(np, FALSE);