Date: Sat, 23 Oct 2021 13:19:17 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 259259] Mk/Uses/emacs.mk: Remove Emacs major version from EMACS_PKGNAMESUFFIX Message-ID: <bug-259259-7788-UEuMvpsXIB@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-259259-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-259259-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D259259 Bryan Drewery <bdrewery@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdrewery@FreeBSD.org --- Comment #8 from Bryan Drewery <bdrewery@FreeBSD.org> --- This patch runs into numerous Poudriere errors. I have not yet figured it o= ut fully, however "" is definitely not going to work. Directly in the ports you can see why: ~/git/ports/main/devel/magit-devel # make -V PKGNAME FLAVOR=3Dfull magit-devel""-3.2.1.76 The "" is taken literally. Making it simply blank works, if I understand the intent right. ~/git/ports/main/devel/magit-devel # make -V PKGNAME FLAVOR=3Dfull magit-devel-3.2.1.76 I haven't finished my analysis but fixing that does allow Poudriere to avoid the errors. Changing to blank does result in these kind of package names if that is expected: [00:00:30] [Dry Run] Deleting dash.el-emacs27-2.19.1_1.pkg: package name changed to 'dash.el' [00:00:30] [Dry Run] Deleting dash.el-emacs27_canna-2.19.1_1.pkg: package n= ame changed to 'dash.el-emacs-canna' [00:00:30] [Dry Run] Deleting dash.el-emacs29-2.19.1_1.pkg: package name changed to 'dash.el-emacs-devel' [00:00:30] [Dry Run] Deleting dash.el-emacs29_nox-2.19.1_1.pkg: package name changed to 'dash.el-emacs-devel-nox' [00:00:30] [Dry Run] Deleting magit-devel-emacs27-3.2.1.76.pkg: package name changed to 'magit-devel' [00:00:30] [Dry Run] Deleting magit-devel-emacs27_canna-3.2.1.76.pkg: packa= ge name changed to 'magit-devel-emacs-canna' [00:00:30] [Dry Run] Deleting magit-devel-emacs29-3.2.1.76.pkg: package name changed to 'magit-devel-emacs-devel' [00:00:30] [Dry Run] Deleting magit-devel-emacs29_nox-3.2.1.76.pkg: package name changed to 'magit-devel-emacs-devel-nox' [00:00:30] [Dry Run] Deleting transient-emacs27-0.3.6_1.pkg: package name changed to 'transient' [00:00:30] [Dry Run] Deleting transient-emacs27_canna-0.3.6_1.pkg: package = name changed to 'transient-emacs-canna' [00:00:30] [Dry Run] Deleting transient-emacs29-0.3.6_1.pkg: package name changed to 'transient-emacs-devel' [00:00:30] [Dry Run] Deleting transient-emacs29_nox-0.3.6_1.pkg: package na= me changed to 'transient-emacs-devel-nox' [00:00:30] [Dry Run] Deleting with-editor-emacs27-3.0.5.pkg: package name changed to 'with-editor' [00:00:30] [Dry Run] Deleting with-editor-emacs27_canna-3.0.5.pkg: package = name changed to 'with-editor-emacs-canna' [00:00:30] [Dry Run] Deleting with-editor-emacs29-3.0.5.pkg: package name changed to 'with-editor-emacs-devel' [00:00:30] [Dry Run] Deleting with-editor-emacs29_nox-3.0.5.pkg: package na= me changed to 'with-editor-emacs-devel-nox' I plan to add a validation to bsd.port.mk about "" being invalid, among whatever else is a problem here. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-259259-7788-UEuMvpsXIB>