From nobody Fri Dec 10 23:51:15 2021 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id BA9EF18EE53C for ; Fri, 10 Dec 2021 23:51:18 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4J9njf2cxmz3R41; Fri, 10 Dec 2021 23:51:18 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from kalamity.joker.local (123-48-130-181.area1b.commufa.jp [123.48.130.181]) (authenticated bits=0) by www121.sakura.ne.jp (8.16.1/8.16.1/[SAKURA-WEB]/20201212) with ESMTPA id 1BANpGVg022335; Sat, 11 Dec 2021 08:51:16 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Sat, 11 Dec 2021 08:51:15 +0900 From: Tomoaki AOKI To: ports@freebsd.org Cc: "Bjoern A. Zeeb" Subject: Re: HEADS-UP: sys/module.h must be included after sys/param.h on main Message-Id: <20211211085115.e3ebb3874e755e898f488861@dec.sakura.ne.jp> In-Reply-To: References: <20211211081102.dd26943d03ce3cb7298aa493@dec.sakura.ne.jp> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd13.0) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4J9njf2cxmz3R41 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N Hi. Original post is not yet delivered... On Fri, 10 Dec 2021 23:25:11 +0000 (UTC) "Bjoern A. Zeeb" wrote: > On Sat, 11 Dec 2021, Tomoaki AOKI wrote: > > Hi, > > > As no one have done heads-up... > > > > On src, "git: df38ada2931f - main - modules: increase MAXMODNAME and > > provide backward compat" [1] mandates includes of sys/module.h after > > sys/param.h. > > That order is suggested by style.9 as well; I think we had only one > case in base not doing that. Missing param.h was more likely but > still minimal. Maybe many porters don't read it. ;-) > > All modules in base are fixed by the commit itself but modules on ports > > are not. > > I am sorry; I hadn't thought about about the possible build issue > there. The major concern on the change was the internal backward > compat issue. Would be difficult for src committers to do thorough build tests for ports. > > Maintainers having any port having kmod need checking and, if affected, > > fix it. > > > > At least, I've bitten by sysutils/acpi_call and x11/nvidia-driver. > > For x11/nvidia-driver, I've uploaded patch on already-reported Bug > > 260318 [2]. Not yet for sysutils/acpi_call. > > Thank you for that! I'd hope that's all of them. > > Is it in both cases include order or is param.h missing at all? Both cases include param.h but mis-ordered. I wonder if includes are alphabetically ordered on many ports. (Excluding all known-to-be-mandatory orders.) > > [1] > > https://lists.freebsd.org/archives/dev-commits-src-main/2021-December/001971.html > > > > [2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260318 > > -- > Bjoern A. Zeeb r15:7 > -- Tomoaki AOKI